Bug 189425

Summary: CBOR coders should only be compiled if WebAuthN is enabled
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebCore Misc.Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jiewen_tan: review+
Patch none

Don Olmstead
Reported 2018-09-07 11:58:25 PDT
Everything else in Modules/webauthn has ENABLE(WEB_AUTHN) guards
Attachments
Patch (4.61 KB, patch)
2018-09-07 12:01 PDT, Don Olmstead 		jiewen_tan: review+
DetailsFormatted DiffDiff
Patch (7.12 KB, patch)
2018-09-10 12:05 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-09-07 12:01:37 PDT
Created attachment 349172 [details] Patch
Jiewen Tan
Comment 2 2018-09-07 12:09:01 PDT
Comment on attachment 349172 [details] Patch Looks good to me.
Don Olmstead
Comment 3 2018-09-10 12:05:54 PDT
Created attachment 349321 [details] Patch Add guards around associated tests.
Jiewen Tan
Comment 4 2018-09-10 13:20:33 PDT
Comment on attachment 349321 [details] Patch Good catch. r=me.
WebKit Commit Bot
Comment 5 2018-09-10 14:11:31 PDT
Comment on attachment 349321 [details] Patch Clearing flags on attachment: 349321 Committed r235861: <https://trac.webkit.org/changeset/235861>
WebKit Commit Bot
Comment 6 2018-09-10 14:11:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-10 14:12:45 PDT
<rdar://problem/44316884>
Note You need to log in before you can comment on or make changes to this bug.