Bug 189400

Summary: Unify most of the WebKit C API sources
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bdakin, berto, cgarcia, commit-queue, ews-watchlist, ggaren, gustavo, Hironori.Fujii, keith_miller, mcatanzaro, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191853
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tim Horton 2018-09-07 01:09:11 PDT 
Unify most of the WebKit C API sources
Comment 1 Tim Horton 2018-09-07 01:09:42 PDT 
Created attachment 349121 [details]
Patch
Comment 2 EWS Watchlist 2018-09-07 01:14:58 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Tim Horton 2018-09-07 01:15:47 PDT 
Created attachment 349122 [details]
Patch
Comment 4 Tim Horton 2018-09-07 01:20:55 PDT 
Created attachment 349123 [details]
Patch
Comment 5 Alex Christensen 2018-09-07 17:09:20 PDT 
Comment on attachment 349123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349123&action=review

Windows failure looks unrelated.

> Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:243
> +                writeToFile(WebKit::NetworkCache::Data(sourceJSON.characters8(), serializedLength));

Would just an initializer list work here?
Comment 6 Tim Horton 2018-09-07 17:10:31 PDT 
(In reply to Alex Christensen from comment #5)
> Comment on attachment 349123 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349123&action=review
> 
> Windows failure looks unrelated.

I thought so too.

> Would just an initializer list work here?

Probably!
Comment 7 WebKit Commit Bot 2018-09-07 17:36:19 PDT 
Comment on attachment 349123 [details]
Patch

Clearing flags on attachment: 349123

Committed r235823: <https://trac.webkit.org/changeset/235823>
Comment 8 WebKit Commit Bot 2018-09-07 17:36:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-09-07 17:37:21 PDT 
<rdar://problem/44246069>
Comment 10 Tim Horton 2018-09-07 20:24:02 PDT 
Follow-up build fix in https://trac.webkit.org/changeset/235826/webkit
Comment 11 Fujii Hironori 2018-09-09 21:45:20 PDT 
Filed for MSVC issue:
  Bug 189467 – [MSVC] X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions