Bug 189398

Summary:

[Win][Clang] Add FloatRect(const RECT&) constructor

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Platform

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

171618

Attachments:

Description	Flags
Patch	none
Patch	none

Fujii Hironori

Reported 2018-09-06 23:38:14 PDT

[Win][Clang] Add FloatRect(const RECT&) constructor While trying to build WebKit WinCairo port with the latest Clang (Bug 171618), The following compilation errors were reported. > [7/664] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\win\PlatformScreenWin.cpp.obj > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/win/PlatformScreenWin.cpp.obj > C:\tools\llvm\bin\clang-cl.exe /nologo -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DHAVE_CONFIG_H=1 -DNOMINMAX -DSTATICALLY_LINKED_WITH_PAL=1 -DUCHAR_TYPE=wchar_t -DUNICODE -DWINVER=0x601 -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -D__STDC_CONSTANT_MACROS -I..\..\WebKitLibraries\win\include -I. -I..\..\Source\WebCore -I..\..\Source\WebCore\Modules\airplay -I..\..\Source\WebCore\Modules\beacon -I..\..\Source\WebCore\Modules\applepay -I..\..\Source\WebCore\Modules\applepay\paymentrequest -I..\..\Source\WebCore\Modules\cache -I..\..\Source\WebCore\Modules\credentialmanagement -I..\..\Source\WebCore\Modules\encryptedmedia -I..\..\Source\WebCore\Modules\encryptedmedia\legacy -I..\..\Source\WebCore\Modules\entriesapi -I..\..\Source\WebCore\Modules\fetch -I..\..\Source\WebCore\Modules\geolocation -I..\..\Source\WebCore\Modules\indexeddb -I..\..\Source\WebCore\Modules\indexeddb\client -I..\..\Source\WebCore\Modules\indexeddb\server -I..\..\Source\WebCore\Modules\indexeddb\shared -I..\..\Source\WebCore\Modules\mediacapabilities -I..\..\Source\WebCore\Modules\mediacontrols -I..\..\Source\WebCore\Modules\mediasession -I..\..\Source\WebCore\Modules\mediasource -I..\..\Source\WebCore\Modules\mediastream -I..\..\Source\WebCore\Modules\navigatorcontentutils -I..\..\Source\WebCore\Modules\notifications -I..\..\Source\WebCore\Modules\paymentrequest -I..\..\Source\WebCore\Modules\plugins -I..\..\Source\WebCore\Modules\quota -I..\..\Source\WebCore\Modules\speech -I..\..\Source\WebCore\Modules\streams -I..\..\Source\WebCore\Modules\webaudio -I..\..\Source\WebCore\Modules\webauthn -I..\..\Source\WebCore\Modules\webdatabase -I..\..\Source\WebCore\Modules\webdriver -I..\..\Source\WebCore\Modules\websockets -I..\..\Source\WebCore\Modules\webvr -I..\..\Source\WebCore\accessibility -I..\..\Source\WebCore\animation -I..\..\Source\WebCore\bindings -I..\..\Source\WebCore\bindings\js -I..\..\Source\WebCore\bridge -I..\..\Source\WebCore\bridge\c -I..\..\Source\WebCore\bridge\jsc -I..\..\Source\WebCore\contentextensions -I..\..\Source\WebCore\crypto -I..\..\Source\WebCore\crypto\algorithms -I..\..\Source\WebCore\crypto\keys -I..\..\Source\WebCore\crypto\parameters -I..\..\Source\WebCore\css -I..\..\Source\WebCore\css\parser -I..\..\Source\WebCore\cssjit -I..\..\Source\WebCore\dom -I..\..\Source\WebCore\dom\default -I..\..\Source\WebCore\dom\messageports -I..\..\Source\WebCore\domjit -I..\..\Source\WebCore\editing -I..\..\Source\WebCore\fileapi -I..\..\Source\WebCore\history -I..\..\Source\WebCore\html -I..\..\Source\WebCore\html\canvas -I..\..\Source\WebCore\html\forms -I..\..\Source\WebCore\html\parser -I..\..\Source\WebCore\html\shadow -I..\..\Source\WebCore\html\track -I..\..\Source\WebCore\inspector -I..\..\Source\WebCore\inspector\agents -I..\..\Source\WebCore\inspector\agents\page -I..\..\Source\WebCore\inspector\agents\worker -I..\..\Source\WebCore\loader -I..\..\Source\WebCore\loader\appcache -I..\..\Source\WebCore\loader\archive -I..\..\Source\WebCore\loader\archive\mhtml -I..\..\Source\WebCore\loader\cache -I..\..\Source\WebCore\loader\icon -I..\..\Source\WebCore\mathml -I..\..\Source\WebCore\page -I..\..\Source\WebCore\page\animation -I..\..\Source\WebCore\page\csp -I..\..\Source\WebCore\page\scrolling -I..\..\Source\WebCore\platform -I..\..\Source\WebCore\platform\animation -I..\..\Source\WebCore\platform\audio -I..\..\Source\WebCore\platform\crypto -I..\..\Source\WebCore\platform\encryptedmedia -I..\..\Source\WebCore\platform\gamepad -I..\..\Source\WebCore\platform\graphics -I..\..\Source\WebCore\platform\graphics\cpu\arm -I..\..\Source\WebCore\platform\graphics\cpu\arm\filters -I..\..\Source\WebCore\platform\graphics\displaylists -I..\..\Source\WebCore\platform\graphics\filters -I..\..\Source\WebCore\platform\graphics\harfbuzz -I..\..\Source\WebCore\platform\graphics\harfbuzz\ng -I..\..\Source\WebCore\platform\graphics\iso -I..\..\Source\WebCore\platform\graphics\opentype -I..\..\Source\WebCore\platform\graphics\transforms -I..\..\Source\WebCore\platform\mediastream -I..\..\Source\WebCore\platform\mediastream\libwebrtc -I..\..\Source\WebCore\platform\mock -I..\..\Source\WebCore\platform\mock\mediasource -I..\..\Source\WebCore\platform\network -I..\..\Source\WebCore\platform\sql -I..\..\Source\WebCore\platform\text -I..\..\Source\WebCore\platform\text\icu -I..\..\Source\WebCore\platform\vr -I..\..\Source\WebCore\plugins -I..\..\Source\WebCore\rendering -I..\..\Source\WebCore\rendering\line -I..\..\Source\WebCore\rendering\mathml -I..\..\Source\WebCore\rendering\shapes -I..\..\Source\WebCore\rendering\style -I..\..\Source\WebCore\rendering\svg -I..\..\Source\WebCore\rendering\updating -I..\..\Source\WebCore\replay -I..\..\Source\WebCore\storage -I..\..\Source\WebCore\style -I..\..\Source\WebCore\svg -I..\..\Source\WebCore\svg\animation -I..\..\Source\WebCore\svg\graphics -I..\..\Source\WebCore\svg\graphics\filters -I..\..\Source\WebCore\svg\properties -I..\..\Source\WebCore\websockets -I..\..\Source\WebCore\workers -I..\..\Source\WebCore\workers\service -I..\..\Source\WebCore\workers\service\context -I..\..\Source\WebCore\workers\service\server -I..\..\Source\WebCore\xml -I..\..\Source\WebCore\xml\parser -IDerivedSources\WebCore -IDerivedSources\ForwardingHeaders\ANGLE -I..\..\Source\WebCore\platform\graphics\gpu -IDerivedSources\ForwardingHeaders -I..\include\private -I..\include\private\JavaScriptCore -I..\..\Source\WebCore\accessibility\win -I..\..\Source\WebCore\page\win -I..\..\Source\WebCore\platform\graphics\egl -I..\..\Source\WebCore\platform\graphics\opengl -I..\..\Source\WebCore\platform\graphics\win -I..\..\Source\WebCore\platform\mediacapabilities -I..\..\Source\WebCore\platform\network\win -I..\..\Source\WebCore\platform\win -I..\..\Source\ThirdParty\ANGLE\include -I..\..\Source\ThirdParty\ANGLE\include\egl -I..\..\Source\WebCore\platform\cf -I..\..\Source\WebCore\platform\cf\win -I..\..\Source\WebCore\platform\graphics\cairo -I..\..\Source\WebCore\platform\network\curl -I..\..\Source\WebCore\platform\image-decoders -I..\..\Source\WebCore\platform\image-decoders\bmp -I..\..\Source\WebCore\platform\image-decoders\gif -I..\..\Source\WebCore\platform\image-decoders\ico -I..\..\Source\WebCore\platform\image-decoders\jpeg -I..\..\Source\WebCore\platform\image-decoders\png -I..\..\Source\WebCore\platform\image-decoders\webp -I..\..\Source\WebCore\platform\graphics\texmap -I..\..\Source\WebCore\loader\archive\cf -I..\..\WebKitLibraries\win\include\cairo -I..\..\Source\bmalloc -IDerivedSources -I..\..\Source\ThirdParty -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wno-unknown-argument -Wno-nonportable-include-path -Wno-unknown-pragmas -Wno-macro-redefined -Wno-undef -m64 -fno-strict-aliasing /MD /Zi /Ob0 /Od /RTC1 /bigobj /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /std:c++17 /utf-8 /validate-charset -fmsc-version=1911 /Yu"WebCorePrefix.h" /FI"WebCorePrefix.h" /Fp"C:/webkit/ga/WebKitBuild/Debug/Source/WebCore/WebCore_SOURCES/WebCorePrefix.pch" /showIncludes /FoSource\WebCore\CMakeFiles\WebCore.dir\platform\win\PlatformScreenWin.cpp.obj /Fdlib64\WebCore.pdb -c ..\..\Source\WebCore\platform\win\PlatformScreenWin.cpp > ..\..\Source\WebCore\platform\win\PlatformScreenWin.cpp(98,12): error: no viable conversion from returned value of type 'RECT' (aka 'tagRECT') to function return type 'WebCore::FloatRect' > return monitorInfo.rcMonitor; > ^~~~~~~~~~~~~~~~~~~~~ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(61,7): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const WebCore::FloatRect &' for 1st argument > class FloatRect { > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(61,7): note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'WebCore::FloatRect &&' for 1st argument > ..\..\Source\WebCore\platform\graphics/FloatRect.h(75,20): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const WebCore::IntRect &' for 1st argument > WEBCORE_EXPORT FloatRect(const IntRect&); > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(193,5): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const cairo_rectangle_t &' (aka 'const _cairo_rectangle &') for 1st argument > FloatRect(const cairo_rectangle_t&); > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(198,20): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const D2D1_RECT_F &' (aka 'const D2D_RECT_F &') for 1st argument > WEBCORE_EXPORT FloatRect(const D2D1_RECT_F&); > ^ > ..\..\Source\WebCore\platform\win\PlatformScreenWin.cpp(104,12): error: no viable conversion from returned value of type 'RECT' (aka 'tagRECT') to function return type 'WebCore::FloatRect' > return monitorInfo.rcWork; > ^~~~~~~~~~~~~~~~~~ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(61,7): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const WebCore::FloatRect &' for 1st argument > class FloatRect { > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(61,7): note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'WebCore::FloatRect &&' for 1st argument > ..\..\Source\WebCore\platform\graphics/FloatRect.h(75,20): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const WebCore::IntRect &' for 1st argument > WEBCORE_EXPORT FloatRect(const IntRect&); > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(193,5): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const cairo_rectangle_t &' (aka 'const _cairo_rectangle &') for 1st argument > FloatRect(const cairo_rectangle_t&); > ^ > ..\..\Source\WebCore\platform\graphics/FloatRect.h(198,20): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const D2D1_RECT_F &' (aka 'const D2D_RECT_F &') for 1st argument > WEBCORE_EXPORT FloatRect(const D2D1_RECT_F&); > ^ > 2 errors generated. > [8/664] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\win\PopupMenuWin.cpp.obj > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/win/PopupMenuWin.cpp.obj > C:\tools\llvm\bin\clang-cl.exe /nologo -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DHAVE_CONFIG_H=1 -DNOMINMAX -DSTATICALLY_LINKED_WITH_PAL=1 -DUCHAR_TYPE=wchar_t -DUNICODE -DWINVER=0x601 -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -D__STDC_CONSTANT_MACROS -I..\..\WebKitLibraries\win\include -I. -I..\..\Source\WebCore -I..\..\Source\WebCore\Modules\airplay -I..\..\Source\WebCore\Modules\beacon -I..\..\Source\WebCore\Modules\applepay -I..\..\Source\WebCore\Modules\applepay\paymentrequest -I..\..\Source\WebCore\Modules\cache -I..\..\Source\WebCore\Modules\credentialmanagement -I..\..\Source\WebCore\Modules\encryptedmedia -I..\..\Source\WebCore\Modules\encryptedmedia\legacy -I..\..\Source\WebCore\Modules\entriesapi -I..\..\Source\WebCore\Modules\fetch -I..\..\Source\WebCore\Modules\geolocation -I..\..\Source\WebCore\Modules\indexeddb -I..\..\Source\WebCore\Modules\indexeddb\client -I..\..\Source\WebCore\Modules\indexeddb\server -I..\..\Source\WebCore\Modules\indexeddb\shared -I..\..\Source\WebCore\Modules\mediacapabilities -I..\..\Source\WebCore\Modules\mediacontrols -I..\..\Source\WebCore\Modules\mediasession -I..\..\Source\WebCore\Modules\mediasource -I..\..\Source\WebCore\Modules\mediastream -I..\..\Source\WebCore\Modules\navigatorcontentutils -I..\..\Source\WebCore\Modules\notifications -I..\..\Source\WebCore\Modules\paymentrequest -I..\..\Source\WebCore\Modules\plugins -I..\..\Source\WebCore\Modules\quota -I..\..\Source\WebCore\Modules\speech -I..\..\Source\WebCore\Modules\streams -I..\..\Source\WebCore\Modules\webaudio -I..\..\Source\WebCore\Modules\webauthn -I..\..\Source\WebCore\Modules\webdatabase -I..\..\Source\WebCore\Modules\webdriver -I..\..\Source\WebCore\Modules\websockets -I..\..\Source\WebCore\Modules\webvr -I..\..\Source\WebCore\accessibility -I..\..\Source\WebCore\animation -I..\..\Source\WebCore\bindings -I..\..\Source\WebCore\bindings\js -I..\..\Source\WebCore\bridge -I..\..\Source\WebCore\bridge\c -I..\..\Source\WebCore\bridge\jsc -I..\..\Source\WebCore\contentextensions -I..\..\Source\WebCore\crypto -I..\..\Source\WebCore\crypto\algorithms -I..\..\Source\WebCore\crypto\keys -I..\..\Source\WebCore\crypto\parameters -I..\..\Source\WebCore\css -I..\..\Source\WebCore\css\parser -I..\..\Source\WebCore\cssjit -I..\..\Source\WebCore\dom -I..\..\Source\WebCore\dom\default -I..\..\Source\WebCore\dom\messageports -I..\..\Source\WebCore\domjit -I..\..\Source\WebCore\editing -I..\..\Source\WebCore\fileapi -I..\..\Source\WebCore\history -I..\..\Source\WebCore\html -I..\..\Source\WebCore\html\canvas -I..\..\Source\WebCore\html\forms -I..\..\Source\WebCore\html\parser -I..\..\Source\WebCore\html\shadow -I..\..\Source\WebCore\html\track -I..\..\Source\WebCore\inspector -I..\..\Source\WebCore\inspector\agents -I..\..\Source\WebCore\inspector\agents\page -I..\..\Source\WebCore\inspector\agents\worker -I..\..\Source\WebCore\loader -I..\..\Source\WebCore\loader\appcache -I..\..\Source\WebCore\loader\archive -I..\..\Source\WebCore\loader\archive\mhtml -I..\..\Source\WebCore\loader\cache -I..\..\Source\WebCore\loader\icon -I..\..\Source\WebCore\mathml -I..\..\Source\WebCore\page -I..\..\Source\WebCore\page\animation -I..\..\Source\WebCore\page\csp -I..\..\Source\WebCore\page\scrolling -I..\..\Source\WebCore\platform -I..\..\Source\WebCore\platform\animation -I..\..\Source\WebCore\platform\audio -I..\..\Source\WebCore\platform\crypto -I..\..\Source\WebCore\platform\encryptedmedia -I..\..\Source\WebCore\platform\gamepad -I..\..\Source\WebCore\platform\graphics -I..\..\Source\WebCore\platform\graphics\cpu\arm -I..\..\Source\WebCore\platform\graphics\cpu\arm\filters -I..\..\Source\WebCore\platform\graphics\displaylists -I..\..\Source\WebCore\platform\graphics\filters -I..\..\Source\WebCore\platform\graphics\harfbuzz -I..\..\Source\WebCore\platform\graphics\harfbuzz\ng -I..\..\Source\WebCore\platform\graphics\iso -I..\..\Source\WebCore\platform\graphics\opentype -I..\..\Source\WebCore\platform\graphics\transforms -I..\..\Source\WebCore\platform\mediastream -I..\..\Source\WebCore\platform\mediastream\libwebrtc -I..\..\Source\WebCore\platform\mock -I..\..\Source\WebCore\platform\mock\mediasource -I..\..\Source\WebCore\platform\network -I..\..\Source\WebCore\platform\sql -I..\..\Source\WebCore\platform\text -I..\..\Source\WebCore\platform\text\icu -I..\..\Source\WebCore\platform\vr -I..\..\Source\WebCore\plugins -I..\..\Source\WebCore\rendering -I..\..\Source\WebCore\rendering\line -I..\..\Source\WebCore\rendering\mathml -I..\..\Source\WebCore\rendering\shapes -I..\..\Source\WebCore\rendering\style -I..\..\Source\WebCore\rendering\svg -I..\..\Source\WebCore\rendering\updating -I..\..\Source\WebCore\replay -I..\..\Source\WebCore\storage -I..\..\Source\WebCore\style -I..\..\Source\WebCore\svg -I..\..\Source\WebCore\svg\animation -I..\..\Source\WebCore\svg\graphics -I..\..\Source\WebCore\svg\graphics\filters -I..\..\Source\WebCore\svg\properties -I..\..\Source\WebCore\websockets -I..\..\Source\WebCore\workers -I..\..\Source\WebCore\workers\service -I..\..\Source\WebCore\workers\service\context -I..\..\Source\WebCore\workers\service\server -I..\..\Source\WebCore\xml -I..\..\Source\WebCore\xml\parser -IDerivedSources\WebCore -IDerivedSources\ForwardingHeaders\ANGLE -I..\..\Source\WebCore\platform\graphics\gpu -IDerivedSources\ForwardingHeaders -I..\include\private -I..\include\private\JavaScriptCore -I..\..\Source\WebCore\accessibility\win -I..\..\Source\WebCore\page\win -I..\..\Source\WebCore\platform\graphics\egl -I..\..\Source\WebCore\platform\graphics\opengl -I..\..\Source\WebCore\platform\graphics\win -I..\..\Source\WebCore\platform\mediacapabilities -I..\..\Source\WebCore\platform\network\win -I..\..\Source\WebCore\platform\win -I..\..\Source\ThirdParty\ANGLE\include -I..\..\Source\ThirdParty\ANGLE\include\egl -I..\..\Source\WebCore\platform\cf -I..\..\Source\WebCore\platform\cf\win -I..\..\Source\WebCore\platform\graphics\cairo -I..\..\Source\WebCore\platform\network\curl -I..\..\Source\WebCore\platform\image-decoders -I..\..\Source\WebCore\platform\image-decoders\bmp -I..\..\Source\WebCore\platform\image-decoders\gif -I..\..\Source\WebCore\platform\image-decoders\ico -I..\..\Source\WebCore\platform\image-decoders\jpeg -I..\..\Source\WebCore\platform\image-decoders\png -I..\..\Source\WebCore\platform\image-decoders\webp -I..\..\Source\WebCore\platform\graphics\texmap -I..\..\Source\WebCore\loader\archive\cf -I..\..\WebKitLibraries\win\include\cairo -I..\..\Source\bmalloc -IDerivedSources -I..\..\Source\ThirdParty -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wno-unknown-argument -Wno-nonportable-include-path -Wno-unknown-pragmas -Wno-macro-redefined -Wno-undef -m64 -fno-strict-aliasing /MD /Zi /Ob0 /Od /RTC1 /bigobj /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /std:c++17 /utf-8 /validate-charset -fmsc-version=1911 /Yu"WebCorePrefix.h" /FI"WebCorePrefix.h" /Fp"C:/webkit/ga/WebKitBuild/Debug/Source/WebCore/WebCore_SOURCES/WebCorePrefix.pch" /showIncludes /FoSource\WebCore\CMakeFiles\WebCore.dir\platform\win\PopupMenuWin.cpp.obj /Fdlib64\WebCore.pdb -c ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp > In file included from ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp:24: > ..\..\Source\WebCore\platform\win/PopupMenuWin.h(45,18): warning: 'show' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void show(const IntRect&, FrameView*, int index); > ^ > ..\..\Source\WebCore\platform\PopupMenu.h(34,18): note: overridden virtual function is here > virtual void show(const IntRect&, FrameView*, int index) = 0; > ^ > In file included from ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp:24: > ..\..\Source\WebCore\platform\win/PopupMenuWin.h(46,18): warning: 'hide' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void hide(); > ^ > ..\..\Source\WebCore\platform\PopupMenu.h(35,18): note: overridden virtual function is here > virtual void hide() = 0; > ^ > In file included from ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp:24: > ..\..\Source\WebCore\platform\win/PopupMenuWin.h(47,18): warning: 'updateFromElement' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void updateFromElement(); > ^ > ..\..\Source\WebCore\platform\PopupMenu.h(36,18): note: overridden virtual function is here > virtual void updateFromElement() = 0; > ^ > In file included from ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp:24: > ..\..\Source\WebCore\platform\win/PopupMenuWin.h(48,18): warning: 'disconnectClient' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void disconnectClient(); > ^ > ..\..\Source\WebCore\platform\PopupMenu.h(37,18): note: overridden virtual function is here > virtual void disconnectClient() = 0; > ^ > ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(103,12): error: no viable conversion from returned value of type 'RECT' (aka 'tagRECT') to function return type 'WebCore::FloatRect' > return monitorInfo.rcWork; > ^~~~~~~~~~~~~~~~~~ > ..\..\Source\WebCore\platform\graphics\FloatRect.h(61,7): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const WebCore::FloatRect &' for 1st argument > class FloatRect { > ^ > ..\..\Source\WebCore\platform\graphics\FloatRect.h(61,7): note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'WebCore::FloatRect &&' for 1st argument > ..\..\Source\WebCore\platform\graphics\FloatRect.h(75,20): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const WebCore::IntRect &' for 1st argument > WEBCORE_EXPORT FloatRect(const IntRect&); > ^ > ..\..\Source\WebCore\platform\graphics\FloatRect.h(193,5): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const cairo_rectangle_t &' (aka 'const _cairo_rectangle &') for 1st argument > FloatRect(const cairo_rectangle_t&); > ^ > ..\..\Source\WebCore\platform\graphics\FloatRect.h(198,20): note: candidate constructor not viable: no known conversion from 'RECT' (aka 'tagRECT') to 'const D2D1_RECT_F &' (aka 'const D2D_RECT_F &') for 1st argument > WEBCORE_EXPORT FloatRect(const D2D1_RECT_F&); > ^ > 4 warnings and 1 error generated.

Attachments
Patch (2.26 KB, patch) 2018-09-07 00:24 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (2.47 KB, patch) 2018-09-09 19:06 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2018-09-07 00:24:28 PDT

Created attachment 349117 [details] Patch

Fujii Hironori

Comment 2 2018-09-09 19:01:12 PDT

Oops. AppleWin EWS fails to build TestWebCoreLib: > C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/FloatRect.h(198): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\FloatRect.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] > c:\cygwin\home\buildbot\webkit\webkitbuild\release\derivedsources\forwardingheaders\webcore\FloatRect.h(198): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\AffineTransform.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] > C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/FloatRect.h(198): error C2143: syntax error: missing ',' before '&' (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\FloatRect.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] > c:\cygwin\home\buildbot\webkit\webkitbuild\release\derivedsources\forwardingheaders\webcore\FloatRect.h(198): error C2143: syntax error: missing ',' before '&' (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\AffineTransform.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj]

Fujii Hironori

Comment 3 2018-09-09 19:06:19 PDT

Created attachment 349293 [details] Patch

Fujii Hironori

Comment 4 2018-09-09 22:13:39 PDT

Comment on attachment 349293 [details] Patch Clearing flags on attachment: 349293 Committed r235840: <https://trac.webkit.org/changeset/235840>

Fujii Hironori

Comment 5 2018-09-09 22:13:43 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-09-09 22:14:19 PDT

<rdar://problem/44291171>

Note You need to log in before you can comment on or make changes to this bug.