Summary: | [Win][Clang] Add FloatRect(const RECT&) constructor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 171618 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2018-09-06 23:38:14 PDT
Created attachment 349117 [details]
Patch
Oops. AppleWin EWS fails to build TestWebCoreLib:
> C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/FloatRect.h(198): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\FloatRect.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj]
> c:\cygwin\home\buildbot\webkit\webkitbuild\release\derivedsources\forwardingheaders\webcore\FloatRect.h(198): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\AffineTransform.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj]
> C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/FloatRect.h(198): error C2143: syntax error: missing ',' before '&' (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\FloatRect.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj]
> c:\cygwin\home\buildbot\webkit\webkitbuild\release\derivedsources\forwardingheaders\webcore\FloatRect.h(198): error C2143: syntax error: missing ',' before '&' (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WebCore\AffineTransform.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj]
Created attachment 349293 [details]
Patch
Comment on attachment 349293 [details] Patch Clearing flags on attachment: 349293 Committed r235840: <https://trac.webkit.org/changeset/235840> All reviewed patches have been landed. Closing bug. |