| Summary: | Add a standalone version of the test runtime tree map viewer, that can accept stats.json from a local test run | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, darin, dbates, ews-watchlist, glenn, mkwst, ryanhaddad, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2018-09-06 21:18:24 PDT
Created attachment 349111 [details]
Patch
This should probably live in some other directory. Maybe it should be bundled in layout_test_results and linked from results.html. Comment on attachment 349111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349111&action=review > Tools/ChangeLog:12 > + This should probably live in some other directory. Maybe it should be bundled in layout_test_results > + and linked from results.html. How about somewhere on build.webkit.org, and having a link to it from "Tests and Performance" section of the landing page? I want someone to be able to see the tree map for their local results, so the page would have to be able to load a local stats.json (and probably the results.json in future). A single click from results.html would be ideal, rather than forcing someone to drag and drop the json file. It that something that you want to figure out before the patch lands? Not sure if it’s meant for review if so. Given its current behavior though, I think that changes in comment 3 may be appropriate before landing. Created attachment 349227 [details]
Patch
Bump. I think we should put this file into fast/harness and include it in layout-test-results, with a link from results.html. Created attachment 407909 [details]
Patch
Committed r266727: <https://trac.webkit.org/changeset/266727> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407909 [details]. |