Bug 18939 – In some float situations, the original layout is wrong and only corrects itself on repaint

• Component: CSS
• Status: RESOLVED FIXED

[Ain Tohvri]

1. Open the attached HTML test case;
2. Click on the 'Age' label;
3. The label and the select input are being moved under the 'Name' input.

HTML/CSS is W3C-valid. 

Works properly in Safari 3.1.1 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; et-ee) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.1 Safari/525.18) and Fx 3 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5).

[Ain Tohvri]

Created attachment 21012 [details]
HTML test case

[Ain Tohvri]

Created attachment 21013 [details]
Form before the click

A form screen before the click on a label

[Ain Tohvri]

Created attachment 21014 [details]
Form after the click

A form screen after the click on a label

[Ain Tohvri]

Issue looks to rely in label padding. With padding removed it works. 

[Tab Atkins]

The behavior that you get after clicking the label is correct - that's the layout that you *should* have, given the particular size and positioning of floats in your testcase.  

The fact that we start out with a different layout (the one you want) is a mistake.  Clicking the label just triggers a repaint which then, for some reason, makes it lay out correctly.

I'm marking this as a valid bug, but altering the title to accurately reflect what's wrong.

[Robert Hogan]

*** Bug 53387 has been marked as a duplicate of this bug. ***

[Robert Hogan]

Created attachment 167563 [details]
Patch

[Levi Weintraub]

Comment on attachment 167563 [details]
Patch

LGTM.

[Build Bot]

Comment on attachment 167563 [details]
Patch

Attachment 167563 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14217546

New failing tests:
fast/block/br-with-clearance-after-collapsing-space.html

[Robert Hogan]

Created attachment 169209 [details]
Patch

[Robert Hogan]

Created attachment 169217 [details]
Patch

[Robert Hogan]

Created attachment 169252 [details]
Patch

[Build Bot]

Comment on attachment 169252 [details]
Patch

Attachment 169252 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14394720

New failing tests:
fast/block/br-with-clearance-after-collapsing-space.html

[Levi Weintraub]

Comment on attachment 169252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169252&action=review

Please don't make the bots red.

> LayoutTests/fast/block/br-with-clearance-after-collapsing-space.html:5
> +  <!--
> +    Test created by Krinkle <krinklemail (at) gmail (d0t) com>
> +  --> 

Is this part really necessary?

> LayoutTests/fast/block/br-with-clearance-after-collapsing-space.html:22
> +    setTimeout("testRunner.notifyDone()", 0);

This should be gated on if testRunner is defined.

[Robert Hogan]

Created attachment 169454 [details]
Patch

[Robert Hogan]

Created attachment 169470 [details]
Patch

[Robert Hogan]

Committed r131999: <http://trac.webkit.org/changeset/131999>