Summary: | [iOS] Arrow keys do not dispatch DOM events to non-editable elements | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, jeremyj-wk, jonlee, megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | iOS 11 | ||||||||
URL: | https://www.icloud.com | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=189388 | ||||||||
Bug Depends on: | 189381, 189432 | ||||||||
Bug Blocks: | 190571 | ||||||||
Attachments: |
|
Description
Daniel Bates
2018-09-06 17:46:12 PDT
Created attachment 349101 [details]
Patch
We will need to fix bug #189388 in order to be able to write a test. Comment on attachment 349101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349101&action=review > Source/WebCore/ChangeLog:16 > + Unfortunately I ran into <https://bugs.webkit.org/show_bug.cgi?id=189388> and hence could > + not write a test for this change. Should we fix that first so we can land with tests? > Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:174 > + return "Unidentified"_s; That's a bit weird to have in production code. Maybe return empty string? There is a related issue with regards to arrow keys and editable elements. See bug #189388. (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 349101 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349101&action=review > > > Source/WebCore/ChangeLog:16 > > + Unfortunately I ran into <https://bugs.webkit.org/show_bug.cgi?id=189388> and hence could > > + not write a test for this change. > > Should we fix that first so we can land with tests? > Will fix this in bug #189432 and update this patch to include updated expected results for the test included in the patch for bug #189432. > > Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:174 > > + return "Unidentified"_s; > > That's a bit weird to have in production code. Maybe return empty string? This is the correct behavior by <https://www.w3.org/TR/uievents-key/#key-Unidentified>. Created attachment 349200 [details] To land after landing bug #189432 Committed r235860: <https://trac.webkit.org/changeset/235860> |