Bug 189381 – Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Today I made some changes in my local working copy that affected the grouping of unified source files such that I got my build failed with the following errors:

[[
In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:1:
platform/ios/wak/WKGraphics.mm:34:17: error: expected namespace name
using namespace WebCore;
                ^
In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3:
platform/ios/wak/WebCoreThread.mm:868:20: error: no member named 'Threading' in namespace 'WebCore'; did you mean 'LogThreading'?
    using WebCore::Threading;
          ~~~~~~~~~^~~~~~~~~
                   LogThreading
In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3:
In file included from platform/ios/wak/WebCoreThread.mm:33:
/Volumes/Data/WebKitDev/Safari/OpenSource/Source/WebCore/platform/Logging.h:109:22: note: 'LogThreading' declared here
WEBCORE_LOG_CHANNELS(DECLARE_LOG_CHANNEL)
                     ^
2 errors generated.
]]

[Daniel Bates]

Created attachment 349088 [details]
Patch

[Daniel Bates]

Comment on attachment 349088 [details]
Patch

Clearing flags on attachment: 349088

Committed r235816: <https://trac.webkit.org/changeset/235816>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44242882>