Bug 189381 - Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading
Summary: Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 189389
  Show dependency treegraph
 
Reported: 2018-09-06 16:01 PDT by Daniel Bates
Modified: 2018-09-07 16:01 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2018-09-06 16:05 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-09-06 16:01:44 PDT
Today I made some changes in my local working copy that affected the grouping of unified source files such that I got my build failed with the following errors:

[[
In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:1:
platform/ios/wak/WKGraphics.mm:34:17: error: expected namespace name
using namespace WebCore;
                ^
In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3:
platform/ios/wak/WebCoreThread.mm:868:20: error: no member named 'Threading' in namespace 'WebCore'; did you mean 'LogThreading'?
    using WebCore::Threading;
          ~~~~~~~~~^~~~~~~~~
                   LogThreading
In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3:
In file included from platform/ios/wak/WebCoreThread.mm:33:
/Volumes/Data/WebKitDev/Safari/OpenSource/Source/WebCore/platform/Logging.h:109:22: note: 'LogThreading' declared here
WEBCORE_LOG_CHANNELS(DECLARE_LOG_CHANNEL)
                     ^
2 errors generated.
]]
Comment 1 Daniel Bates 2018-09-06 16:05:18 PDT
Created attachment 349088 [details]
Patch
Comment 2 Daniel Bates 2018-09-07 16:00:15 PDT
Comment on attachment 349088 [details]
Patch

Clearing flags on attachment: 349088

Committed r235816: <https://trac.webkit.org/changeset/235816>
Comment 3 Daniel Bates 2018-09-07 16:00:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-09-07 16:01:26 PDT
<rdar://problem/44242882>