Summary: | [GTK] Plugins not resized | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marco Barisione <marco.barisione> | ||||||
Component: | WebKitGTK | Assignee: | marcoil <marc.ordinasillopis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alp, andersca, aroben, marc.ordinasillopis, tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Marco Barisione
2008-05-08 02:50:15 PDT
Created attachment 21255 [details] Fixes the issue for r33931 This patch ensures that changes in the geometry are sent to the plugin when the PluginView is the whole document (NP_FULL). I forgot to mention that for the fix to work, the patches for Gtk present in bug #18935 have to be applied. The issue does exist and the patch fixes GTK, but Anders remarked that this fix is wrong. Anders, could you elaborate? Hum... Adam Roben or someone who hacks on windows should take a look at this. Created attachment 21856 [details] Fix for r34689 I've made a new patch that should fix the issue without affecting the Windows port. I've used XP_UNIX because the X11 Qt port has the same behavior. Comment on attachment 21856 [details] Fix for r34689 Looks good to me. I would've thought that set should _always_ call setNPWindowRect, even in a windowed resize, but it seems that is not necessary. This patch is safe in any case I would say. |