Bug 189364

Summary: Actively prewarm processes created for prewarm pool
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch
cdumez: review+
patch
none
patch none

Description Antti Koivisto 2018-09-06 12:33:56 PDT
Prewarming can speed up first page load in a process.
Comment 1 Antti Koivisto 2018-09-06 12:56:54 PDT
Created attachment 349055 [details]
patch
Comment 2 EWS Watchlist 2018-09-06 13:00:32 PDT
Attachment 349055 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ProcessWarming.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/page/ProcessWarming.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2018-09-06 13:14:24 PDT
Created attachment 349058 [details]
patch
Comment 4 Antti Koivisto 2018-09-06 13:15:38 PDT
Created attachment 349059 [details]
patch
Comment 5 Chris Dumez 2018-09-06 13:40:16 PDT
Comment on attachment 349059 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349059&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:608
> +    WebCore::ProcessWarming::prewarm();

We likely do not need the WebCore::

> Source/WebKit/WebProcess/WebProcess.h:133
> +    void prewarm();

Does this really need to be public ?
Comment 6 Antti Koivisto 2018-09-06 13:47:16 PDT
Created attachment 349066 [details]
patch
Comment 7 Antti Koivisto 2018-09-06 14:08:22 PDT
Created attachment 349069 [details]
patch
Comment 8 WebKit Commit Bot 2018-09-06 14:37:23 PDT
Comment on attachment 349069 [details]
patch

Clearing flags on attachment: 349069

Committed r235758: <https://trac.webkit.org/changeset/235758>
Comment 9 WebKit Commit Bot 2018-09-06 14:37:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-09-06 14:38:23 PDT
<rdar://problem/44197960>