Summary: | Actively prewarm processes created for prewarm pool | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | beidson, cdumez, commit-queue, ews-watchlist, ggaren, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2018-09-06 12:33:56 PDT
Created attachment 349055 [details]
patch
Attachment 349055 [details] did not pass style-queue:
ERROR: Source/WebCore/page/ProcessWarming.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/page/ProcessWarming.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 349058 [details]
patch
Created attachment 349059 [details]
patch
Comment on attachment 349059 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=349059&action=review > Source/WebKit/WebProcess/WebProcess.cpp:608 > + WebCore::ProcessWarming::prewarm(); We likely do not need the WebCore:: > Source/WebKit/WebProcess/WebProcess.h:133 > + void prewarm(); Does this really need to be public ? Created attachment 349066 [details]
patch
Created attachment 349069 [details]
patch
Comment on attachment 349069 [details] patch Clearing flags on attachment: 349069 Committed r235758: <https://trac.webkit.org/changeset/235758> All reviewed patches have been landed. Closing bug. |