Bug 189356

Summary: [macOS] [WK2] Support changing attributes for selected text (text shadow, underline, strike-through)
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 189295    
Bug Blocks: 189383    
Attachments:
Description Flags
Blocked on webkit.org/b/189295
none
Rebase on trunk
none
Fix build for SDK < macOS 10.13 none

Wenson Hsieh
Reported 2018-09-06 10:14:46 PDT
...using controls on the NSFontPanel.
Attachments
Blocked on webkit.org/b/189295 (33.79 KB, patch)
2018-09-06 11:49 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on trunk (33.92 KB, patch)
2018-09-06 13:01 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix build for SDK < macOS 10.13 (34.10 KB, patch)
2018-09-06 13:38 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-06 10:15:43 PDT
<rdar://problem/44185674>
Wenson Hsieh
Comment 2 2018-09-06 11:49:33 PDT
Created attachment 349049 [details] Blocked on webkit.org/b/189295
Ryosuke Niwa
Comment 3 2018-09-06 12:48:29 PDT
Could you update the patch for trunk?
Wenson Hsieh
Comment 4 2018-09-06 13:01:07 PDT
(In reply to Ryosuke Niwa from comment #3) > Could you update the patch for trunk? Yep, now that r235748 is in!
Wenson Hsieh
Comment 5 2018-09-06 13:01:13 PDT
Created attachment 349056 [details] Rebase on trunk
Wenson Hsieh
Comment 6 2018-09-06 13:38:41 PDT
Created attachment 349064 [details] Fix build for SDK < macOS 10.13
WebKit Commit Bot
Comment 7 2018-09-06 17:05:39 PDT
Comment on attachment 349064 [details] Fix build for SDK < macOS 10.13 Clearing flags on attachment: 349064 Committed r235769: <https://trac.webkit.org/changeset/235769>
WebKit Commit Bot
Comment 8 2018-09-06 17:05:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.