Bug 189352

Summary: Group options of scrollRectToVisible into a struct
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: UI EventsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 188043    
Attachments:
Description Flags
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2018-09-06 08:05:45 PDT
RenderLayer::scrollRectToVisible and RenderObject::scrollRectToVisible have several parameters to configure the type of scrolling. We could group them into a single struct to make easier to modify parameters in the future (e.g. add an ifdefed scroll behavior option in bug 188043). Maybe this could help too for bug 176454 and bug 161611.
Comment 1 Frédéric Wang (:fredw) 2018-09-06 08:29:04 PDT
Created attachment 349027 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-09-06 09:15:21 PDT
Created attachment 349030 [details]
Patch
Comment 3 WebKit Commit Bot 2018-09-06 12:48:15 PDT
Comment on attachment 349030 [details]
Patch

Clearing flags on attachment: 349030

Committed r235749: <https://trac.webkit.org/changeset/235749>
Comment 4 WebKit Commit Bot 2018-09-06 12:48:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-06 12:49:27 PDT
<rdar://problem/44192485>