Bug 189352 - Group options of scrollRectToVisible into a struct
Summary: Group options of scrollRectToVisible into a struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 188043
  Show dependency tree / graph
 
Reported: 2018-09-06 08:05 PDT by Frédéric Wang (:fredw)
Modified: 2018-09-06 12:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (24.63 KB, patch)
2018-09-06 08:29 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (25.23 KB, patch)
2018-09-06 09:15 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-09-06 08:05:45 PDT 
RenderLayer::scrollRectToVisible and RenderObject::scrollRectToVisible have several parameters to configure the type of scrolling. We could group them into a single struct to make easier to modify parameters in the future (e.g. add an ifdefed scroll behavior option in bug 188043). Maybe this could help too for bug 176454 and bug 161611.
Comment 1 Frédéric Wang (:fredw) 2018-09-06 08:29:04 PDT 
Created attachment 349027 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-09-06 09:15:21 PDT 
Created attachment 349030 [details]
Patch
Comment 3 WebKit Commit Bot 2018-09-06 12:48:15 PDT 
Comment on attachment 349030 [details]
Patch

Clearing flags on attachment: 349030

Committed r235749: <https://trac.webkit.org/changeset/235749>
Comment 4 WebKit Commit Bot 2018-09-06 12:48:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-06 12:49:27 PDT 
<rdar://problem/44192485>