Bug 189313

Summary: [CMake] Allow port specific options on gtest
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2018-09-05 12:19:20 PDT
Currently there is no way for a port to configure gtest. The options are also not readily available to TestWebKitAPI.
Attachments
Patch (5.07 KB, patch)
2018-09-05 12:28 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-09-05 12:28:53 PDT
Created attachment 348954 [details] Patch
Don Olmstead
Comment 2 2018-09-05 12:46:54 PDT
Ports may want to set any one of the variables set in https://github.com/google/googletest/blob/release-1.8.1/googletest/include/gtest/internal/gtest-port.h#L46-L115 to describe their environment so this allows that.
WebKit Commit Bot
Comment 3 2018-09-05 20:46:24 PDT
Comment on attachment 348954 [details] Patch Clearing flags on attachment: 348954 Committed r235718: <https://trac.webkit.org/changeset/235718>
WebKit Commit Bot
Comment 4 2018-09-05 20:46:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.