Bug 189313 - [CMake] Allow port specific options on gtest
Summary: [CMake] Allow port specific options on gtest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-05 12:19 PDT by Don Olmstead
Modified: 2018-09-05 20:47 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.07 KB, patch)
2018-09-05 12:28 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-09-05 12:19:20 PDT
Currently there is no way for a port to configure gtest. The options are also not readily available to TestWebKitAPI.
Comment 1 Don Olmstead 2018-09-05 12:28:53 PDT
Created attachment 348954 [details]
Patch
Comment 2 Don Olmstead 2018-09-05 12:46:54 PDT
Ports may want to set any one of the variables set in https://github.com/google/googletest/blob/release-1.8.1/googletest/include/gtest/internal/gtest-port.h#L46-L115 to describe their environment so this allows that.
Comment 3 WebKit Commit Bot 2018-09-05 20:46:24 PDT
Comment on attachment 348954 [details]
Patch

Clearing flags on attachment: 348954

Committed r235718: <https://trac.webkit.org/changeset/235718>
Comment 4 WebKit Commit Bot 2018-09-05 20:46:26 PDT
All reviewed patches have been landed.  Closing bug.