Bug 189302

Summary:

REGRESSION: -webkit-appearance test case crashes

Product:

WebKit

Reporter:

Simon Pieters (:zcorpan) <zcorpan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, pxlcoder, simon.fraser, timothy, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test reduction	none
Patch	none
Patch	none

Description Simon Pieters (:zcorpan) 2018-09-05 05:23:50 PDT

https://bug1368555.bmoattachments.org/attachment.cgi?id=8923730

Scroll somewhere to the right. Safari TP release 64 (Safari 12.1, WebKit 13607.1.3.3) crashes. Safari stable 11.1.2 does not crash.

Comment 1 Alexey Proskuryakov 2018-09-05 10:06:31 PDT

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000001413b1913 WebCore::RenderThemeMac::paintSearchFieldCancelButton(WebCore::RenderBox const&, WebCore::PaintInfo const&, WebCore::IntRect const&) + 1363
1   com.apple.WebCore             	0x000000014221c65c WebCore::RenderTheme::paint(WebCore::RenderBox const&, WebCore::ControlStates&, WebCore::PaintInfo const&, WebCore::LayoutRect const&) + 1564
2   com.apple.WebCore             	0x0000000140df3fef WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 943
3   com.apple.WebCore             	0x0000000140df143b WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 75
...

Comment 2 Radar WebKit Bug Importer 2018-09-05 10:06:48 PDT

<rdar://problem/44143049>

Comment 3 zalan 2019-01-02 14:16:40 PST

Created attachment 358204 [details]
Test reduction

Comment 4 zalan 2019-01-03 14:33:29 PST

Created attachment 358278 [details]
Patch

Comment 5 Wenson Hsieh 2019-01-03 14:38:19 PST

Comment on attachment 358278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358278&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:2080
> +    // Set horizontal position back to based on the content direction (cancelButtonRectForBounds() only knows about system direction).

Nit - I think you missed a word in "…back to based on the…"

Comment 6 zalan 2019-01-03 14:52:21 PST

Created attachment 358280 [details]
Patch

Comment 7 WebKit Commit Bot 2019-01-03 18:34:30 PST

Comment on attachment 358280 [details]
Patch

Clearing flags on attachment: 358280

Committed r239604: <https://trac.webkit.org/changeset/239604>

Comment 8 WebKit Commit Bot 2019-01-03 18:34:31 PST

All reviewed patches have been landed.  Closing bug.