Bug 189298

Summary: Update code style guidelines for using namespace inside a namespace definition
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit WebsiteAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: jond, keith_miller, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-09-04 23:25:48 PDT
Update code style guidelines for using namespace inside a namespace definition https://webkit.org/code-style-guidelines/#using-position > [](#using-position) In implementation files, put all other "using" statements at the beginning of the file, before any namespace definitions and after any "include" statements. > > ###### Right: > > ```cpp > // HTMLSelectElement.cpp > > using namespace other; > > namespace WebCore { > > } // namespace WebCore > ``` > > ###### Wrong: > > ```cpp > // HTMLSelectElement.cpp > > namespace WebCore { > > using namespace other; > > } // namespace WebCore > ``` [webkit-dev] Moving WebCore to unified source builds and style changes. https://lists.webkit.org/pipermail/webkit-dev/2017-October/029656.html > 1) Move all “using namespace <name>;” inside the WebCore namespace (they used to be in the global namespace) and change to "using WebCore::<type-name>;” in .mm files.
Attachments
Patch (1.73 KB, patch)
2018-09-04 23:37 PDT, Fujii Hironori
no flags
Fujii Hironori
Comment 1 2018-09-04 23:37:17 PDT
Fujii Hironori
Comment 2 2018-09-05 19:55:46 PDT
Comment on attachment 348897 [details] Patch Clearing flags on attachment: 348897 Committed r235717: <https://trac.webkit.org/changeset/235717>
Fujii Hironori
Comment 3 2018-09-05 19:55:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-09-05 19:56:21 PDT
Note You need to log in before you can comment on or make changes to this bug.