| Summary: | [macOS] Cannot change font size at selection until font panel is shown | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, ews-watchlist, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||
| Bug Blocks: | 189356 | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Wenson Hsieh
2018-09-04 21:24:19 PDT
Created attachment 348892 [details]
WIP
Created attachment 348947 [details]
WIP 2
Created attachment 348981 [details]
First pass
Created attachment 348984 [details]
Rebase on trunk
Created attachment 348986 [details]
Try to fix the build
Created attachment 348989 [details]
Fix 32-bit macOS build
Comment on attachment 348989 [details] Fix 32-bit macOS build Attachment 348989 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9108959 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html Created attachment 348995 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 348989 [details]
Fix 32-bit macOS build
r=me. This patch probably didn't introduce a regression in backdrop filter LOL.
(In reply to Ryosuke Niwa from comment #9) > Comment on attachment 348989 [details] > Fix 32-bit macOS build > > r=me. This patch probably didn't introduce a regression in backdrop filter > LOL. Yeah, this backdrop filter test passes locally for me (and I've also seen it flaky on other unrelated patches on EWS), but I'll do another EWS run to be on the safe side. Created attachment 349029 [details]
Patch for EWS
Created attachment 349050 [details]
Patch for landing
Comment on attachment 349050 [details] Patch for landing Clearing flags on attachment: 349050 Committed r235748: <https://trac.webkit.org/changeset/235748> All reviewed patches have been landed. Closing bug. |