Bug 189295

Summary: [macOS] Cannot change font size at selection until font panel is shown
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, ews-watchlist, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189356    
Attachments:
Description Flags
WIP
none
WIP 2
none
First pass
none
Rebase on trunk
none
Try to fix the build
none
Fix 32-bit macOS build
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch for EWS
none
Patch for landing none

Wenson Hsieh
Reported 2018-09-04 21:24:19 PDT
<rdar://problem/35593389>
Attachments
WIP (63.77 KB, patch)
2018-09-04 21:33 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
WIP 2 (73.39 KB, patch)
2018-09-05 11:19 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
First pass (79.17 KB, patch)
2018-09-05 17:00 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on trunk (78.34 KB, patch)
2018-09-05 17:24 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Try to fix the build (77.94 KB, patch)
2018-09-05 17:46 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix 32-bit macOS build (77.98 KB, patch)
2018-09-05 18:07 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.10 MB, application/zip)
2018-09-05 19:42 PDT, EWS Watchlist 		no flags
Details
Patch for EWS (78.43 KB, patch)
2018-09-06 08:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (78.43 KB, patch)
2018-09-06 12:08 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-09-04 21:33:57 PDT
Created attachment 348892 [details] WIP
Wenson Hsieh
Comment 2 2018-09-05 11:19:48 PDT
Created attachment 348947 [details] WIP 2
Wenson Hsieh
Comment 3 2018-09-05 17:00:35 PDT
Created attachment 348981 [details] First pass
Wenson Hsieh
Comment 4 2018-09-05 17:24:42 PDT
Created attachment 348984 [details] Rebase on trunk
Wenson Hsieh
Comment 5 2018-09-05 17:46:24 PDT
Created attachment 348986 [details] Try to fix the build
Wenson Hsieh
Comment 6 2018-09-05 18:07:05 PDT
Created attachment 348989 [details] Fix 32-bit macOS build
EWS Watchlist
Comment 7 2018-09-05 19:42:17 PDT
Comment on attachment 348989 [details] Fix 32-bit macOS build Attachment 348989 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9108959 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html
EWS Watchlist
Comment 8 2018-09-05 19:42:19 PDT
Created attachment 348995 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Ryosuke Niwa
Comment 9 2018-09-05 22:04:58 PDT
Comment on attachment 348989 [details] Fix 32-bit macOS build r=me. This patch probably didn't introduce a regression in backdrop filter LOL.
Wenson Hsieh
Comment 10 2018-09-06 07:29:45 PDT
(In reply to Ryosuke Niwa from comment #9) > Comment on attachment 348989 [details] > Fix 32-bit macOS build > > r=me. This patch probably didn't introduce a regression in backdrop filter > LOL. Yeah, this backdrop filter test passes locally for me (and I've also seen it flaky on other unrelated patches on EWS), but I'll do another EWS run to be on the safe side.
Wenson Hsieh
Comment 11 2018-09-06 08:45:36 PDT
Created attachment 349029 [details] Patch for EWS
Wenson Hsieh
Comment 12 2018-09-06 12:08:34 PDT
Created attachment 349050 [details] Patch for landing
WebKit Commit Bot
Comment 13 2018-09-06 12:46:45 PDT
Comment on attachment 349050 [details] Patch for landing Clearing flags on attachment: 349050 Committed r235748: <https://trac.webkit.org/changeset/235748>
WebKit Commit Bot
Comment 14 2018-09-06 12:46:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.