Bug 189282

Summary: [CMake] Make TestWebKitAPI dependencies explicit
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, ews-watchlist, Hironori.Fujii, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2018-09-04 16:24:29 PDT
The config.h file in TestWebKitAPI is for all the Test* builds. This means that TestWTF can technically depend on headers from JavaScriptCore, WebCore and WebKit.
Attachments
Patch (7.44 KB, patch)
2018-09-04 16:28 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.44 KB, patch)
2018-09-04 16:33 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-09-04 16:28:20 PDT
Created attachment 348867 [details] Patch
EWS Watchlist
Comment 2 2018-09-04 16:30:26 PDT
Attachment 348867 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/CMakeLists.txt:19: Alphabetical sorting problem. "JavaScriptCoreForwardingHeaders" should be before "WTFForwardingHeaders". [list/order] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-09-04 16:33:27 PDT
Created attachment 348872 [details] Patch
Fujii Hironori
Comment 4 2018-09-04 18:01:35 PDT
I fixed this issue in Bug 184441. How can you reproduce?
Don Olmstead
Comment 5 2018-09-04 18:04:43 PDT
(In reply to Fujii Hironori from comment #4) > I fixed this issue in Bug 184441. > How can you reproduce? Have an empty WebKitBuild. build-webkit --generate-project-only cd WebKitBuild/Release ninja TestWTF Or create a visual studio build and try and build TestWTF first.
Fujii Hironori
Comment 6 2018-09-04 18:23:49 PDT
Comment on attachment 348872 [details] Patch You are right. I fixed a problem only for GTK and WPE. This patch looks good to me.
Don Olmstead
Comment 7 2018-09-04 18:26:13 PDT
(In reply to Fujii Hironori from comment #6) > Comment on attachment 348872 [details] > Patch > > You are right. I fixed a problem only for GTK and WPE. This patch looks good > to me. Thanks! This should make it so TestWTF never fails to compile due to missing headers.
WebKit Commit Bot
Comment 8 2018-09-04 18:52:07 PDT
Comment on attachment 348872 [details] Patch Clearing flags on attachment: 348872 Committed r235653: <https://trac.webkit.org/changeset/235653>
WebKit Commit Bot
Comment 9 2018-09-04 18:52:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.