Bug 189273

Summary: Add WinCairo to bot watcher's dashboard.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, don.olmstead, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Screenshot none

Ross Kirsling
Reported 2018-09-04 13:56:45 PDT
Add WinCairo to bot watcher's dashboard.
Attachments
Patch (36.20 KB, patch)
2018-09-04 14:00 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Screenshot (989.83 KB, image/png)
2018-09-05 09:48 PDT, Ross Kirsling 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-09-04 14:00:01 PDT
Created attachment 348846 [details] Patch
Daniel Bates
Comment 2 2018-09-04 20:45:25 PDT
Comment on attachment 348846 [details] Patch What license does the Windows logo have? Is it compatible with our BSD license?
Ross Kirsling
Comment 3 2018-09-05 08:49:59 PDT
(In reply to Daniel Bates from comment #2) > Comment on attachment 348846 [details] > Patch > > What license does the Windows logo have? Is it compatible with our BSD > license? I grabbed it from Wikimedia Commons, where it's claimed to be public domain (as it is too simplistic to be copyrighted). We actually already have a Windows8.png in that directory that could be used for 10 instead, but technically it seems they updated the blue hue, so I thought I'd make a new one as with the various Mac releases. FWIW, seems like the only attribution listed in that folder is for the Linux penguin that WPE is using.
Lucas Forschler
Comment 4 2018-09-05 09:02:56 PDT
This looks ok to me... Aakash, do we have a UAT environment for the dashboard by chance?
Aakash Jain
Comment 5 2018-09-05 09:25:24 PDT
(In reply to Lucas Forschler from comment #4) > This looks ok to me... Aakash, do we have a UAT environment for the dashboard by chance? We do have UAT. However, dashboard changes can easily be tested locally as well.
Ross Kirsling
Comment 6 2018-09-05 09:48:15 PDT
Created attachment 348932 [details] Screenshot Seems to look as intended when serving the dashboard directory locally.
WebKit Commit Bot
Comment 7 2018-09-05 10:58:52 PDT
Comment on attachment 348846 [details] Patch Clearing flags on attachment: 348846 Committed r235678: <https://trac.webkit.org/changeset/235678>
WebKit Commit Bot
Comment 8 2018-09-05 10:58:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-09-05 10:59:29 PDT
<rdar://problem/44145189>
Note You need to log in before you can comment on or make changes to this bug.