Bug 189265
| Summary: | Rename scroll-snap-margin to scroll-margin, and have it apply when scrolling to anchors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michał Gołębiowski-Owczarek <m.goleb+bugzilla> |
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | 22bpower+bugtracking, bfulgham, collimarco91, contact, dev, emily.meroni, mrobinson, netleon6, simon.fraser, stefanprobst, tannerhodges, trentprynn, vertigoback, webkit-bug-importer, wenson_hsieh, zalan |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WebExposed |
| Version: | Safari Technology Preview | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 218075, 218076 | ||
| Bug Blocks: | 218115 | ||
Michał Gołębiowski-Owczarek
It looks that the CSS Scroll Snap spec has changed and what was named `scroll-snap-margin` is now named `scroll-margin`. The just released Chrome 69 supports only `scroll-margin`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mikaela Young
Scroll margin should also still be applied when snapping is not turned on or applied to the element, allowing it's use with anchor links.
See https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-margin.
Radar WebKit Bug Importer
<rdar://problem/56875889>
Simon Fraser (smfr)
*** Bug 208110 has been marked as a duplicate of this bug. ***
dakur
Any news on this please? It would save a lot of pain when linking to URLs with hash as current hack with negative margin-top & positive padding-top is not reliable as it brings new issues with overlaying elements.
Ben Frain
Pretty standard stuff this. Any ETA on when we might see it in WebKit?
netleon6@gmail.com
scroll-margin & scroll-snap-margin not working in Safari
Please add this, make us easy to access the web
don't make it partial on some browsers it will work on some don't
netleon6@gmail.com
(In reply to Ben Frain from comment #5)
> Pretty standard stuff this. Any ETA on when we might see it in WebKit?
Do you think they reading this!!
Simon Fraser (smfr)
They is
Emily
Also interested in the resolution of this bug in the near future, so that we can get rid of ad-hoc JS code. Thanks!
Martin Robinson
I've decided to divide this work into at least two dependent bugs.
dakur
Thank you! Just for tracking purposes, these two bugs are follow-ups from this one:
- https://bugs.webkit.org/show_bug.cgi?id=218075
- https://bugs.webkit.org/show_bug.cgi?id=218076
Martin Robinson
Both dependent bugs have been closed, so I think this can be closed as well.