Bug 189258

Summary: Add basic support for ScrollIntoViewOptions
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: DOMAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, fred.wang, rwlbuis, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161611, 188043    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch none

Frédéric Wang (:fredw)
Reported 2018-09-04 03:09:47 PDT
Created attachment 348810 [details] WIP Patch See bug 161611 comment 6.
Attachments
WIP Patch (21.71 KB, patch)
2018-09-04 03:09 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
WIP Patch (21.71 KB, patch)
2018-09-04 05:32 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (35.40 KB, patch)
2018-09-04 09:03 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.25 MB, application/zip)
2018-09-04 11:06 PDT, EWS Watchlist 		no flags
Details
Patch (37.07 KB, patch)
2018-09-04 12:15 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (38.35 KB, patch)
2018-09-04 12:18 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (38.40 KB, patch)
2018-09-04 14:51 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-09-04 05:32:41 PDT
Created attachment 348813 [details] WIP Patch
Frédéric Wang (:fredw)
Comment 2 2018-09-04 09:03:07 PDT
Created attachment 348815 [details] Patch
EWS Watchlist
Comment 3 2018-09-04 11:06:57 PDT
Comment on attachment 348815 [details] Patch Attachment 348815 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9089965 New failing tests: imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-smooth.html
EWS Watchlist
Comment 4 2018-09-04 11:06:59 PDT
Created attachment 348828 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Frédéric Wang (:fredw)
Comment 5 2018-09-04 12:15:02 PDT
Created attachment 348837 [details] Patch
Frédéric Wang (:fredw)
Comment 6 2018-09-04 12:18:33 PDT
Created attachment 348838 [details] Patch
Simon Fraser (smfr)
Comment 7 2018-09-04 13:40:34 PDT
Comment on attachment 348838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348838&action=review > Source/WebCore/page/ScrollLogicalPosition.h:24 > +enum class ScrollLogicalPosition { enum class ScrollLogicalPosition : uint8_t
Frédéric Wang (:fredw)
Comment 8 2018-09-04 14:51:50 PDT
Created attachment 348849 [details] Patch
WebKit Commit Bot
Comment 9 2018-09-04 22:20:05 PDT
Comment on attachment 348849 [details] Patch Clearing flags on attachment: 348849 Committed r235659: <https://trac.webkit.org/changeset/235659>
WebKit Commit Bot
Comment 10 2018-09-04 22:20:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-09-04 22:21:19 PDT
<rdar://problem/44126818>
Note You need to log in before you can comment on or make changes to this bug.