Bug 189258 - Add basic support for ScrollIntoViewOptions
Summary: Add basic support for ScrollIntoViewOptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 161611 188043
  Show dependency treegraph
 
Reported: 2018-09-04 03:09 PDT by Frédéric Wang (:fredw)
Modified: 2018-09-04 22:21 PDT (History)
8 users (show)

See Also:


Attachments
WIP Patch (21.71 KB, patch)
2018-09-04 03:09 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
WIP Patch (21.71 KB, patch)
2018-09-04 05:32 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (35.40 KB, patch)
2018-09-04 09:03 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.25 MB, application/zip)
2018-09-04 11:06 PDT, Build Bot
no flags Details
Patch (37.07 KB, patch)
2018-09-04 12:15 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (38.35 KB, patch)
2018-09-04 12:18 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (38.40 KB, patch)
2018-09-04 14:51 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-09-04 03:09:47 PDT
Created attachment 348810 [details]
WIP Patch

See bug 161611 comment 6.
Comment 1 Frédéric Wang (:fredw) 2018-09-04 05:32:41 PDT
Created attachment 348813 [details]
WIP Patch
Comment 2 Frédéric Wang (:fredw) 2018-09-04 09:03:07 PDT
Created attachment 348815 [details]
Patch
Comment 3 Build Bot 2018-09-04 11:06:57 PDT
Comment on attachment 348815 [details]
Patch

Attachment 348815 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9089965

New failing tests:
imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-smooth.html
Comment 4 Build Bot 2018-09-04 11:06:59 PDT
Created attachment 348828 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 5 Frédéric Wang (:fredw) 2018-09-04 12:15:02 PDT
Created attachment 348837 [details]
Patch
Comment 6 Frédéric Wang (:fredw) 2018-09-04 12:18:33 PDT
Created attachment 348838 [details]
Patch
Comment 7 Simon Fraser (smfr) 2018-09-04 13:40:34 PDT
Comment on attachment 348838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348838&action=review

> Source/WebCore/page/ScrollLogicalPosition.h:24
> +enum class ScrollLogicalPosition {

enum class ScrollLogicalPosition : uint8_t
Comment 8 Frédéric Wang (:fredw) 2018-09-04 14:51:50 PDT
Created attachment 348849 [details]
Patch
Comment 9 WebKit Commit Bot 2018-09-04 22:20:05 PDT
Comment on attachment 348849 [details]
Patch

Clearing flags on attachment: 348849

Committed r235659: <https://trac.webkit.org/changeset/235659>
Comment 10 WebKit Commit Bot 2018-09-04 22:20:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-09-04 22:21:19 PDT
<rdar://problem/44126818>