Bug 189243

Summary: [WPE][GTK] Add more unused result warnings to JSC API
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
[WPE][GTK] Add more unused result warnings to JSC API none

Michael Catanzaro
Reported 2018-09-03 06:02:12 PDT
Add more unused result warnings to JSC API, as suggested by Carlos Garcia
Attachments
[WPE][GTK] Add more unused result warnings to JSC API (2.65 KB, patch)
2018-09-03 06:04 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-09-03 06:04:42 PDT
Created attachment 348767 [details] [WPE][GTK] Add more unused result warnings to JSC API
Carlos Garcia Campos
Comment 2 2018-09-03 06:12:37 PDT
Comment on attachment 348767 [details] [WPE][GTK] Add more unused result warnings to JSC API What about jsc_value_constructor_call and jsc_value_constructor_callv? Is it more obvious that you should get a value in those cases?
Michael Catanzaro
Comment 3 2018-09-03 06:48:47 PDT
Nope, I just grepped for "evaluate" because you suggested that one, I didn't consider jsc_value_constructor_call(). Will add it there too
Michael Catanzaro
Comment 4 2018-09-03 06:51:36 PDT
Wait, no, it is indeed more obvious that you should get a value from those, because they're constructors. Why would you call a constructor and not expect to get a value. :P So yes, it's not needed there IMO.
WebKit Commit Bot
Comment 5 2018-09-04 07:49:03 PDT
Comment on attachment 348767 [details] [WPE][GTK] Add more unused result warnings to JSC API Clearing flags on attachment: 348767 Committed r235612: <https://trac.webkit.org/changeset/235612>
WebKit Commit Bot
Comment 6 2018-09-04 07:49:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.