Bug 189240

Summary: [EME] Add the WebM initData support in ClearKey CDM
Product: WebKit Reporter: Yacine Bandou <bandou.yacine>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, calvaris, commit-queue, olivier.blin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 189238    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Yacine Bandou
Reported 2018-09-03 03:14:13 PDT
Add the "webm" initDataType support in ClearKey CDM. Read the WebM initData by following the W3C spec https://www.w3.org/TR/eme-initdata-webm/#common-system
Attachments
Patch (4.63 KB, patch)
2018-09-03 06:53 PDT, Yacine Bandou 		no flags
DetailsFormatted DiffDiff
Patch (4.64 KB, patch)
2018-09-04 02:09 PDT, Yacine Bandou 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yacine Bandou
Comment 1 2018-09-03 06:53:59 PDT
Created attachment 348770 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-09-04 01:24:24 PDT
Comment on attachment 348770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348770&action=review > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:266 > +static Ref<SharedBuffer> getKeyidFromWebMInitData(const SharedBuffer& initData) To be coherent with the rest of the file this should be called extractKeyIdFrom... (please, mind the capital I of KeyId).
Yacine Bandou
Comment 3 2018-09-04 02:09:30 PDT
Created attachment 348809 [details] Patch
WebKit Commit Bot
Comment 4 2018-09-04 03:27:37 PDT
Comment on attachment 348809 [details] Patch Clearing flags on attachment: 348809 Committed r235610: <https://trac.webkit.org/changeset/235610>
WebKit Commit Bot
Comment 5 2018-09-04 03:27:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-04 03:28:50 PDT
<rdar://problem/44092389>
Note You need to log in before you can comment on or make changes to this bug.