Bug 189211

Summary: Added runtime feature flag for web API statistics
Product: WebKit Reporter: Woodrow Wang <wwang153>
Component: New BugsAssignee: Woodrow Wang <wwang153>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, pvollan, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187773    
Attachments:
Description Flags
Patch
none
Patch
dbates: review+, commit-queue: commit-queue-
Patch none

Description Woodrow Wang 2018-08-31 14:43:19 PDT
Added runtime feature flag for web API statistics
Comment 1 Woodrow Wang 2018-08-31 14:45:14 PDT
Created attachment 348673 [details]
Patch
Comment 2 Woodrow Wang 2018-09-04 11:11:57 PDT
Created attachment 348829 [details]
Patch
Comment 3 Daniel Bates 2018-09-04 13:27:24 PDT
Comment on attachment 348829 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-09-05 09:33:41 PDT
Comment on attachment 348829 [details]
Patch

Rejecting attachment 348829 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 348829, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9103196
Comment 5 Woodrow Wang 2018-09-05 09:43:34 PDT
Created attachment 348931 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-05 12:03:19 PDT
Comment on attachment 348931 [details]
Patch

Clearing flags on attachment: 348931

Committed r235683: <https://trac.webkit.org/changeset/235683>
Comment 7 Radar WebKit Bug Importer 2018-09-05 14:37:24 PDT
<rdar://problem/44154721>