Bug 189211 - Added runtime feature flag for web API statistics
Summary: Added runtime feature flag for web API statistics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Woodrow Wang
URL:
Keywords: InRadar
Depends on:
Blocks: 187773
  Show dependency treegraph
 
Reported: 2018-08-31 14:43 PDT by Woodrow Wang
Modified: 2018-09-05 14:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2018-08-31 14:45 PDT, Woodrow Wang
no flags Details | Formatted Diff | Diff
Patch (7.36 KB, patch)
2018-09-04 11:11 PDT, Woodrow Wang
dbates: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (7.39 KB, patch)
2018-09-05 09:43 PDT, Woodrow Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Woodrow Wang 2018-08-31 14:43:19 PDT
Added runtime feature flag for web API statistics
Comment 1 Woodrow Wang 2018-08-31 14:45:14 PDT
Created attachment 348673 [details]
Patch
Comment 2 Woodrow Wang 2018-09-04 11:11:57 PDT
Created attachment 348829 [details]
Patch
Comment 3 Daniel Bates 2018-09-04 13:27:24 PDT
Comment on attachment 348829 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-09-05 09:33:41 PDT
Comment on attachment 348829 [details]
Patch

Rejecting attachment 348829 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 348829, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9103196
Comment 5 Woodrow Wang 2018-09-05 09:43:34 PDT
Created attachment 348931 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-05 12:03:19 PDT
Comment on attachment 348931 [details]
Patch

Clearing flags on attachment: 348931

Committed r235683: <https://trac.webkit.org/changeset/235683>
Comment 7 Radar WebKit Bug Importer 2018-09-05 14:37:24 PDT
<rdar://problem/44154721>