Bug 189193

Summary: [LFC] Add margin box verification back now that Display::Box has non-computed horizontal margin.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

alan
Reported 2018-08-31 07:59:21 PDT
ssia
Attachments
Patch (8.70 KB, patch)
2018-08-31 09:13 PDT, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-08-31 09:13:19 PDT
Created attachment 348641 [details] Patch
Antti Koivisto
Comment 2 2018-08-31 10:39:32 PDT
Comment on attachment 348641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348641&action=review > Source/WebCore/layout/Verification.cpp:132 > + borderBox.top() - displayBox.nonCollapsedMarginTop() > + , borderBox.left() - displayBox.nonComputedMarginLeft() > + , displayBox.nonComputedMarginLeft() + borderBox.width() + displayBox.nonComputedMarginRight() > + , displayBox.nonCollapsedMarginTop() + borderBox.height() + displayBox.nonCollapsedMarginBottom() Those commas would look better at the end of the line.
alan
Comment 3 2018-08-31 11:07:52 PDT
Committed r235561: <https://trac.webkit.org/changeset/235561>
Radar WebKit Bug Importer
Comment 4 2018-08-31 11:08:19 PDT
<rdar://problem/43947398>
Note You need to log in before you can comment on or make changes to this bug.