Bug 189188

Summary: REGRESSION(r235484) _WKPreferencesGetWebRTCLegacyAPIEnabled symbol not found when running Safari with external SDK build
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: WebRTCAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, rwlbuis, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=189040
https://bugs.webkit.org/show_bug.cgi?id=189234
Attachments:
Description Flags
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2018-08-31 01:43:02 PDT 
After the change in bug 189040, I can no longer run Safari (iOS or macOS) using the external SDK:

$ Tools/Scripts/run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/fred/WebKit/WebKitBuild//Debug.
dyld: Symbol not found: _WKPreferencesGetWebRTCLegacyAPIEnabled
  Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
  Expected in: /Users/fred/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit
 in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
Comment 1 Frédéric Wang (:fredw) 2018-08-31 02:38:39 PDT 
Created attachment 348624 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-08-31 07:00:39 PDT 
Created attachment 348637 [details]
Patch
Comment 3 youenn fablet 2018-08-31 08:22:21 PDT 
Comment on attachment 348637 [details]
Patch

Thanks!
Comment 4 WebKit Commit Bot 2018-08-31 08:52:56 PDT 
Comment on attachment 348637 [details]
Patch

Clearing flags on attachment: 348637

Committed r235553: <https://trac.webkit.org/changeset/235553>
Comment 5 WebKit Commit Bot 2018-08-31 08:52:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-31 08:53:32 PDT 
<rdar://problem/43941821>