Bug 189188 - REGRESSION(r235484) _WKPreferencesGetWebRTCLegacyAPIEnabled symbol not found when running Safari with external SDK build
Summary: REGRESSION(r235484) _WKPreferencesGetWebRTCLegacyAPIEnabled symbol not found ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-31 01:43 PDT by Frédéric Wang (:fredw)
Modified: 2018-09-02 15:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.02 KB, patch)
2018-08-31 02:38 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (5.34 KB, patch)
2018-08-31 07:00 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-08-31 01:43:02 PDT 
After the change in bug 189040, I can no longer run Safari (iOS or macOS) using the external SDK:

$ Tools/Scripts/run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/fred/WebKit/WebKitBuild//Debug.
dyld: Symbol not found: _WKPreferencesGetWebRTCLegacyAPIEnabled
  Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
  Expected in: /Users/fred/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit
 in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
Comment 1 Frédéric Wang (:fredw) 2018-08-31 02:38:39 PDT 
Created attachment 348624 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-08-31 07:00:39 PDT 
Created attachment 348637 [details]
Patch
Comment 3 youenn fablet 2018-08-31 08:22:21 PDT 
Comment on attachment 348637 [details]
Patch

Thanks!
Comment 4 WebKit Commit Bot 2018-08-31 08:52:56 PDT 
Comment on attachment 348637 [details]
Patch

Clearing flags on attachment: 348637

Committed r235553: <https://trac.webkit.org/changeset/235553>
Comment 5 WebKit Commit Bot 2018-08-31 08:52:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-31 08:53:32 PDT 
<rdar://problem/43941821>