Bug 189180

Summary:

Move stats gathering out of LibWebRTCMediaEndpoint

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, commit-queue, eric.carlson, ews-watchlist, jonlee, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2018-08-30 21:17:35 PDT

refactoring to ease future developments

Attachments
Patch (46.70 KB, patch) 2018-08-30 21:40 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (46.72 KB, patch) 2018-08-30 21:47 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (47.55 KB, patch) 2018-08-31 13:46 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-08-30 21:40:33 PDT

Created attachment 348598 [details] Patch

EWS Watchlist

Comment 2 2018-08-30 21:42:31 PDT

Attachment 348598 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 3 2018-08-30 21:47:22 PDT

Created attachment 348602 [details] Patch

EWS Watchlist

Comment 4 2018-08-30 21:49:40 PDT

Attachment 348602 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alejandro G. Castro

Comment 5 2018-08-31 06:18:46 PDT

Comment on attachment 348602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348602&action=review LGTM > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. 2018 > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. 2018

Jon Lee

Comment 6 2018-08-31 13:22:30 PDT

Comment on attachment 348602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348602&action=review > Source/WebCore/ChangeLog:13 > + * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: Please update the copyright years on these files.

youenn fablet

Comment 7 2018-08-31 13:46:53 PDT

Created attachment 348670 [details] Patch for landing

EWS Watchlist

Comment 8 2018-08-31 13:48:15 PDT

Attachment 348670 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 9 2018-08-31 13:48:29 PDT

(In reply to youenn fablet from comment #7) > Created attachment 348670 [details] > Patch for landing Thanks for the review, I updated copyrights accordingly.

WebKit Commit Bot

Comment 10 2018-08-31 16:27:29 PDT

Comment on attachment 348670 [details] Patch for landing Clearing flags on attachment: 348670 Committed r235576: <https://trac.webkit.org/changeset/235576>

WebKit Commit Bot

Comment 11 2018-08-31 16:27:30 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2018-08-31 16:28:16 PDT

<rdar://problem/43960905>

Note You need to log in before you can comment on or make changes to this bug.