Bug 189171

Summary:

Introduce LibWebRTC backends for sender and receiver

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none

youenn fablet

Reported 2018-08-30 13:43:06 PDT

This is a first step towards using libwebrtc sender and receiver objects when unified plan is on.

Attachments
WIP (72.54 KB, patch) 2018-08-30 13:53 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (62.07 KB, patch) 2018-08-30 15:46 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (64.16 KB, patch) 2018-08-30 15:55 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (64.16 KB, patch) 2018-08-30 16:34 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (64.35 KB, patch) 2018-08-30 16:55 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (64.36 KB, patch) 2018-08-30 21:11 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (64.40 KB, patch) 2018-08-30 21:50 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (67.12 KB, patch) 2018-09-04 09:48 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (65.49 KB, patch) 2018-09-04 10:01 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-08-30 13:53:37 PDT

Created attachment 348541 [details] WIP

youenn fablet

Comment 2 2018-08-30 15:46:06 PDT

Created attachment 348558 [details] Patch

youenn fablet

Comment 3 2018-08-30 15:55:24 PDT

Created attachment 348560 [details] Patch

EWS Watchlist

Comment 4 2018-08-30 15:57:45 PDT

Attachment 348560 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 5 2018-08-30 16:34:20 PDT

Created attachment 348565 [details] Patch

EWS Watchlist

Comment 6 2018-08-30 16:36:03 PDT

Attachment 348565 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 7 2018-08-30 16:55:29 PDT

Created attachment 348569 [details] Patch

EWS Watchlist

Comment 8 2018-08-30 16:58:44 PDT

Attachment 348569 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:1566: The item "Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp" should be added only once to the list. [list/duplicate] [5] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 9 2018-08-30 21:11:25 PDT

Created attachment 348590 [details] Patch

EWS Watchlist

Comment 10 2018-08-30 21:13:47 PDT

Attachment 348590 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 11 2018-08-30 21:50:44 PDT

Created attachment 348603 [details] Patch

EWS Watchlist

Comment 12 2018-08-30 21:52:58 PDT

Attachment 348603 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 13 2018-08-30 23:33:17 PDT

Comment on attachment 348603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348603&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:55 > + RTCRtpParameters getParameters(RTCRtpSender&) const final; Can probably move these two as private.

Alejandro G. Castro

Comment 14 2018-08-31 05:35:19 PDT

Comment on attachment 348603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348603&action=review LGTM, let's do it. > Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h:2 > + * Copyright (C) 2015 Ericsson AB. All rights reserved. Probably you want to add Apple for this new file. > Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h:16 > + * 3. Neither the name of Ericsson nor the names of its contributors > + * may be used to endorse or promote products derived from this > + * software without specific prior written permission. And remove this.

youenn fablet

Comment 15 2018-09-04 09:48:36 PDT

Created attachment 348821 [details] Patch for landing

EWS Watchlist

Comment 16 2018-09-04 09:52:38 PDT

Attachment 348821 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 17 2018-09-04 10:01:13 PDT

Created attachment 348823 [details] Patch for landing

EWS Watchlist

Comment 18 2018-09-04 10:04:30 PDT

Attachment 348823 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 19 2018-09-04 11:48:46 PDT

Comment on attachment 348823 [details] Patch for landing Clearing flags on attachment: 348823 Committed r235623: <https://trac.webkit.org/changeset/235623>

WebKit Commit Bot

Comment 20 2018-09-04 11:48:48 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 21 2018-09-04 11:49:46 PDT

<rdar://problem/44106285>

Note You need to log in before you can comment on or make changes to this bug.