Bug 189169

Summary:

Replace OptionSet |= and -= operators with add() and remove() functions

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bfulgham, commit-queue, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	none
patch	none
patch	none
patch	none
patch	none

Antti Koivisto

Reported 2018-08-30 13:22:04 PDT

It makes code more readable.

Attachments
patch (99.41 KB, patch) 2018-08-30 14:19 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (102.74 KB, patch) 2018-08-31 00:50 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (103.66 KB, patch) 2018-08-31 01:15 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (104.48 KB, patch) 2018-08-31 02:06 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (108.89 KB, patch) 2018-08-31 02:53 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (114.17 KB, patch) 2018-08-31 03:03 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (118.55 KB, patch) 2018-08-31 04:00 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (123.86 KB, patch) 2018-08-31 04:47 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2018-08-30 14:19:22 PDT

Created attachment 348548 [details] patch

EWS Watchlist

Comment 2 2018-08-30 14:22:48 PDT

Attachment 348548 [details] did not pass style-queue: ERROR: Source/WebCore/dom/UserActionElementSet.cpp:69: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 3 2018-08-31 00:50:10 PDT

Created attachment 348618 [details] patch

EWS Watchlist

Comment 4 2018-08-31 00:53:10 PDT

Attachment 348618 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/OptionSet.cpp:111: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 5 2018-08-31 01:15:37 PDT

Created attachment 348620 [details] patch

Antti Koivisto

Comment 6 2018-08-31 02:06:28 PDT

Created attachment 348622 [details] patch

Antti Koivisto

Comment 7 2018-08-31 02:53:59 PDT

Created attachment 348626 [details] patch

Antti Koivisto

Comment 8 2018-08-31 03:03:05 PDT

Created attachment 348628 [details] patch