Bug 189157

Summary: Web Share API compatible with AppleTV and WatchOS
Product: WebKit Reporter: Olivia Barnett <obarnett>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, jlewis3, realdawei, ryanhaddad, thorton, tsavell, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Olivia Barnett
Reported 2018-08-30 10:22:57 PDT
Web Share API compatible with AppleTV and WatchOS
Attachments
Patch (6.71 KB, patch)
2018-08-30 10:23 PDT, Olivia Barnett 		no flags
DetailsFormatted DiffDiff
Patch (6.93 KB, patch)
2018-08-30 10:38 PDT, Olivia Barnett 		no flags
DetailsFormatted DiffDiff
Patch (6.79 KB, patch)
2018-08-30 10:42 PDT, Olivia Barnett 		no flags
DetailsFormatted DiffDiff
Patch (6.74 KB, patch)
2018-08-30 10:44 PDT, Olivia Barnett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Olivia Barnett
Comment 1 2018-08-30 10:23:50 PDT
Created attachment 348503 [details] Patch
Tim Horton
Comment 2 2018-08-30 10:26:20 PDT
Comment on attachment 348503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348503&action=review > Source/WebKit/Shared/WebPreferencesDefaultValues.h:81 > +#define DEFAULT_WEB_SHARE_ENABLED true Now it’s not defined to anything on those platforms. Put this in its own section down near the bottom, with just two cases (iOS and not watch and not tv -> true, otherwise false).
Olivia Barnett
Comment 3 2018-08-30 10:38:33 PDT
Created attachment 348505 [details] Patch
Tim Horton
Comment 4 2018-08-30 10:42:00 PDT
Comment on attachment 348505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348505&action=review > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:26 > +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) This went too far north! Config.h and the file’s own header always come first
Olivia Barnett
Comment 5 2018-08-30 10:42:11 PDT
Created attachment 348506 [details] Patch
Olivia Barnett
Comment 6 2018-08-30 10:44:26 PDT
Created attachment 348507 [details] Patch
Tim Horton
Comment 7 2018-08-30 11:12:00 PDT
Comment on attachment 348507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348507&action=review > Source/WebKit/ChangeLog:3 > + Web Share API compatible with AppleTV and WatchOS For next time (but not this time since it's already in the CQ) the title ideally should either describe the /problem/ or say "Fix the build..."
WebKit Commit Bot
Comment 8 2018-08-30 11:30:06 PDT
Comment on attachment 348507 [details] Patch Clearing flags on attachment: 348507 Committed r235512: <https://trac.webkit.org/changeset/235512>
WebKit Commit Bot
Comment 9 2018-08-30 11:30:08 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 10 2018-08-31 02:44:16 PDT
(In reply to WebKit Commit Bot from comment #8) > Comment on attachment 348507 [details] > Patch > > Clearing flags on attachment: 348507 > > Committed r235512: <https://trac.webkit.org/changeset/235512> Follow-up build fix: Committed r235520: <https://trac.webkit.org/changeset/235520>
Radar WebKit Bug Importer
Comment 11 2018-08-31 02:44:33 PDT
<rdar://problem/43932330>
David Kilzer (:ddkilzer)
Comment 12 2018-08-31 02:55:43 PDT
(In reply to David Kilzer (:ddkilzer) from comment #10) > (In reply to WebKit Commit Bot from comment #8) > > Comment on attachment 348507 [details] > > Patch > > > > Clearing flags on attachment: 348507 > > > > Committed r235512: <https://trac.webkit.org/changeset/235512> > > Follow-up build fix: > > Committed r235520: <https://trac.webkit.org/changeset/235520> And I think: Committed r235530: <https://trac.webkit.org/changeset/235530>
David Kilzer (:ddkilzer)
Comment 13 2018-08-31 02:58:35 PDT
(In reply to David Kilzer (:ddkilzer) from comment #12) > (In reply to David Kilzer (:ddkilzer) from comment #10) > > (In reply to WebKit Commit Bot from comment #8) > > > Comment on attachment 348507 [details] > > > Patch > > > > > > Clearing flags on attachment: 348507 > > > > > > Committed r235512: <https://trac.webkit.org/changeset/235512> > > > > Follow-up build fix: > > > > Committed r235520: <https://trac.webkit.org/changeset/235520> > > And I think: > > Committed r235530: <https://trac.webkit.org/changeset/235530> And finally(?): Committed r235534: <https://trac.webkit.org/changeset/235534>
Note You need to log in before you can comment on or make changes to this bug.