Bug 189148

Summary: WKNavigation.ProcessCrashDuringCallback is failing on iOS
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Tools / TestsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191783
Bug Depends on: 189037    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2018-08-29 23:38:23 PDT
From https://bugs.webkit.org/show_bug.cgi?id=189037, we know: 1. Errors can occur in completion handler of [webView _getContentsAsStringWithCompletionHandler] because web processes are killed. So we should just keep the change of expectation in 189037. 2. webView can be destroyed before web process exits, as we receive an error WKErrorWebViewInvalidated instead of WKErrorWebContentProcessTerminated. So we need to remove "webView = nullptr;".
Attachments
Patch (1.55 KB, patch)
2018-08-29 23:50 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2018-08-29 23:50:11 PDT
Created attachment 348488 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-30 10:03:09 PDT
Comment on attachment 348488 [details] Patch Clearing flags on attachment: 348488 Committed r235509: <https://trac.webkit.org/changeset/235509>
WebKit Commit Bot
Comment 3 2018-08-30 10:03:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-31 08:56:58 PDT
<rdar://problem/43941972>
Note You need to log in before you can comment on or make changes to this bug.