Bug 189148 - WKNavigation.ProcessCrashDuringCallback is failing on iOS
Summary: WKNavigation.ProcessCrashDuringCallback is failing on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on: 189037
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-29 23:38 PDT by Sihui Liu
Modified: 2018-11-16 19:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2018-08-29 23:50 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-08-29 23:38:23 PDT 
From https://bugs.webkit.org/show_bug.cgi?id=189037, we know:
1. Errors can occur in completion handler of [webView _getContentsAsStringWithCompletionHandler] because web processes are killed.
So we should just keep the change of expectation in 189037.
2. webView can be destroyed before web process exits, as we receive an error WKErrorWebViewInvalidated instead of WKErrorWebContentProcessTerminated. 
So we need to remove "webView = nullptr;".
Comment 1 Sihui Liu 2018-08-29 23:50:11 PDT 
Created attachment 348488 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-30 10:03:09 PDT 
Comment on attachment 348488 [details]
Patch

Clearing flags on attachment: 348488

Committed r235509: <https://trac.webkit.org/changeset/235509>
Comment 3 WebKit Commit Bot 2018-08-30 10:03:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-31 08:56:58 PDT 
<rdar://problem/43941972>