Bug 189141

Summary: [LFC][Margins] Add non-computed horizontal margins to DisplayBox
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

zalan
Reported 2018-08-29 19:54:21 PDT
in-flow block boxes' horizontal margin extends to the containing block's content box. In some cases (float avoiding) we need the non-extended, original values.
Attachments
Patch (16.70 KB, patch)
2018-08-29 20:00 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (17.90 KB, patch)
2018-08-29 21:15 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-08-29 20:00:34 PDT
Created attachment 348473 [details] Patch
zalan
Comment 2 2018-08-29 21:15:35 PDT
Created attachment 348482 [details] Patch
Antti Koivisto
Comment 3 2018-08-30 06:42:54 PDT
Comment on attachment 348482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:241 > + return WidthAndMargin { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } }; return { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } } ; should work too?
Antti Koivisto
Comment 4 2018-08-30 06:45:35 PDT
Comment on attachment 348482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:420 > + return { *left, *right, { *width, { *marginLeft, *marginRight }, {nonComputedMarginLeft, nonComputedMarginRight } } }; Missing space before nonComputedMarginLeft
zalan
Comment 5 2018-08-30 07:25:59 PDT
Committed r235501: <https://trac.webkit.org/changeset/235501>
Radar WebKit Bug Importer
Comment 6 2018-08-30 07:26:14 PDT
<rdar://problem/43884877>
Note You need to log in before you can comment on or make changes to this bug.