| Summary: | Web Inspector: Dark Mode - Sidebar Class Toggle Button Wrong Color | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jamal Nasser <jamaln> | ||||||||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, jamaln, joepeck, mattbaker, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 348466 [details]
Proposed patch @ lines 1163-1165
Uses correct variable for color
Created attachment 348468 [details]
Screenshot of correct text color
Created attachment 348639 [details]
Patch
Comment on attachment 348639 [details]
Patch
rs=me
Comment on attachment 348639 [details] Patch Rejecting attachment 348639 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 348639, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=348639&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189139&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 348639 from bug 189139. Fetching: https://bugs.webkit.org/attachment.cgi?id=348639 Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource From https://git.webkit.org/git/WebKit 65619d48525..9223bcce80b master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 235558 = 65619d485251a3ffd87b48ab29b342956f3dcdc7 r235559 = 1716794964edcbc43fbefdc4c20a77cbb66fb682 r235560 = 9223bcce80b93e8f41d8ad6651a023b14a7181b9 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/9052320 Created attachment 348678 [details]
Patch
Comment on attachment 348678 [details] Patch Clearing flags on attachment: 348678 Committed r235577: <https://trac.webkit.org/changeset/235577> All reviewed patches have been landed. Closing bug. Nice! Thanks for the fix! =) |
Created attachment 348465 [details] Screenshot of wrong text color Class button on sidebar isn't the right color when using dark mode in web inspector.