Bug 189093

Summary:

[CMake] Split Tools/CMakeLists.txt into platform files

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, commit-queue, don.olmstead, mcatanzaro, webkit-bug-importer

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Don Olmstead

Reported 2018-08-29 12:16:20 PDT

Currently Tools/CMakeLists.txt is a big if else statement. Split this into Platform${PORT} files for ease of use especially for out of trunk ports.

Attachments
Patch (3.95 KB, patch) 2018-08-29 12:19 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (3.89 KB, patch) 2018-08-29 12:20 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2018-08-29 12:19:31 PDT

Created attachment 348421 [details] Patch Splits the contents of CMakeLists.txt into Platform${PORT} files

Don Olmstead

Comment 2 2018-08-29 12:20:52 PDT

Created attachment 348422 [details] Patch

Alex Christensen

Comment 3 2018-08-29 12:26:16 PDT

Looks good. Please add a ChangeLog

Don Olmstead

Comment 4 2018-08-29 12:31:59 PDT

(In reply to Alex Christensen from comment #3) > Looks good. Please add a ChangeLog prepare-Changelog is just making one for Tools. Should it be modifying the root changelog?

Alex Christensen

Comment 5 2018-08-29 12:34:42 PDT

Tools/ChangeLog

Don Olmstead

Comment 6 2018-08-29 12:36:35 PDT

Comment on attachment 348422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348422&action=review > Tools/ChangeLog:13 > +2018-08-29 Don Olmstead <don.olmstead@sony.com> > + > + [CMake] Split Tools/CMakeLists.txt into platform files > + https://bugs.webkit.org/show_bug.cgi?id=189093 > + > + Reviewed by NOBODY (OOPS!). > + > + * CMakeLists.txt: > + * PlatformGTK.cmake: Added. > + * PlatformMac.cmake: Added. > + * PlatformWPE.cmake: Added. > + * PlatformWin.cmake: Added. > + Its over here

Michael Catanzaro

Comment 7 2018-08-29 12:40:11 PDT

Comment on attachment 348422 [details] Patch Yeah, this is nicer. And I see the ChangeLog is there!

Alex Christensen

Comment 8 2018-08-29 13:04:57 PDT

Comment on attachment 348422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348422&action=review >> Tools/ChangeLog:13 >> + > > Its over here How did I miss this :( Yep, it's fine.

Don Olmstead

Comment 9 2018-08-29 13:13:48 PDT

(In reply to Alex Christensen from comment #8) > Comment on attachment 348422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348422&action=review > > >> Tools/ChangeLog:13 > >> + > > > > Its over here > > How did I miss this :( > Yep, it's fine. We'll chalk it up to not enough ☕ this morning :) Will land after EWS hears back from all the CMake ports.

Don Olmstead

Comment 10 2018-08-29 13:29:10 PDT

Comment on attachment 348422 [details] Patch Tests are running and build on AppleWin so I think we're good

WebKit Commit Bot

Comment 11 2018-08-29 13:55:35 PDT

Comment on attachment 348422 [details] Patch Clearing flags on attachment: 348422 Committed r235477: <https://trac.webkit.org/changeset/235477>

WebKit Commit Bot

Comment 12 2018-08-29 13:55:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.