Bug 189072

Summary:

[CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, ddkilzer, mitz, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=188754

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Darin Adler 2018-08-28 19:32:39 PDT

[CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently

Comment 1 Darin Adler 2018-08-28 19:42:40 PDT

Created attachment 348380 [details]
Patch

Comment 2 Darin Adler 2018-08-28 20:34:40 PDT

Created attachment 348383 [details]
Patch

Comment 3 Darin Adler 2018-08-28 21:10:53 PDT

Created attachment 348387 [details]
Patch

Comment 4 Darin Adler 2018-08-29 19:40:24 PDT

Created attachment 348471 [details]
Patch

Comment 5 Darin Adler 2018-09-01 13:58:55 PDT

Created attachment 348716 [details]
Patch

Comment 6 mitz 2018-09-01 18:08:09 PDT

Comment on attachment 348716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348716&action=review

I’d r+ but I don’t see an r?.

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:177
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)

Not new to this patch, but in SPI headers we should be using the SDK version rather than the deployment target, since the goal of the header is to reflect the contents of an internal SDK header.

Comment 7 Darin Adler 2018-09-01 19:26:31 PDT

Comment on attachment 348716 [details]
Patch

Just noticed this is finally building, so setting review? on it now.

Comment 8 Darin Adler 2018-09-01 19:28:16 PDT

(In reply to mitz from comment #6)
> > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:177
> > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)
> 
> Not new to this patch, but in SPI headers we should be using the SDK version
> rather than the deployment target, since the goal of the header is to
> reflect the contents of an internal SDK header.

That sounds exactly right to me, but I don’t understand it well enough to know exactly what to do. I would be happy to help fix it at any time, but I don’t want to risk breaking this patch by trying it as part of this one.

Comment 9 WebKit Commit Bot 2018-09-01 19:55:05 PDT

Comment on attachment 348716 [details]
Patch

Clearing flags on attachment: 348716

Committed r235585: <https://trac.webkit.org/changeset/235585>

Comment 10 WebKit Commit Bot 2018-09-01 19:55:07 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 Radar WebKit Bug Importer 2018-09-01 19:56:19 PDT

<rdar://problem/44038929>

Comment 12 David Kilzer (:ddkilzer) 2018-09-05 04:48:07 PDT

(In reply to WebKit Commit Bot from comment #9)
> Comment on attachment 348716 [details]
> Patch
> 
> Clearing flags on attachment: 348716
> 
> Committed r235585: <https://trac.webkit.org/changeset/235585>

Follow-up fix to remove references to WebDownloadInternal.h from the WebKitLegacy Xcode project:

Committed r235663: <https://trac.webkit.org/changeset/235663>