Bug 189055

Summary:

[IntersectionObserver] Implement intersection logic for the same-document implicit root case

Product:

WebKit

Reporter:

Ali Juma <ajuma>

Component:

Layout and Rendering

Assignee:

Ali Juma <ajuma>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159475

Attachments:

Description	Flags
Patch	none

Description Ali Juma 2018-08-28 13:37:58 PDT

Extend the intersection logic to handle computing the intersection of the target and the viewport, for the case where the target is in the main frame.

Comment 1 Ali Juma 2018-08-28 13:44:52 PDT

Created attachment 348336 [details]
Patch

Comment 2 Simon Fraser (smfr) 2018-08-28 15:17:39 PDT

Comment on attachment 348336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348336&action=review

> Source/WebCore/dom/Document.cpp:7465
> +        if (!rootRenderer->isContainingBlockAncestorFor(*targetRenderer))

Shame we have to do an ancestor walk here.

Comment 3 WebKit Commit Bot 2018-08-29 05:36:21 PDT

Comment on attachment 348336 [details]
Patch

Clearing flags on attachment: 348336

Committed r235459: <https://trac.webkit.org/changeset/235459>

Comment 4 WebKit Commit Bot 2018-08-29 05:36:23 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-08-29 05:37:16 PDT

<rdar://problem/43838709>