Bug 189036

Summary: Reenable -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2018-08-27 16:58:02 PDT
Reenable -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
Attachments
Patch (30.90 KB, patch)
2018-08-27 17:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (243.44 KB, patch)
2018-08-28 08:27 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-08-27 16:58:33 PDT
These flags were disable during latest libwebrtc update to ease the refresh, let's reenable them.
youenn fablet
Comment 2 2018-08-27 17:07:58 PDT
Created attachment 348240 [details] Patch
youenn fablet
Comment 3 2018-08-28 08:27:27 PDT
Created attachment 348293 [details] Patch
Geoffrey Garen
Comment 4 2018-08-28 10:06:57 PDT
Comment on attachment 348293 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-08-28 11:00:53 PDT
Comment on attachment 348293 [details] Patch Clearing flags on attachment: 348293 Committed r235430: <https://trac.webkit.org/changeset/235430>
WebKit Commit Bot
Comment 6 2018-08-28 11:00:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-28 11:02:13 PDT
<rdar://problem/43804855>
Note You need to log in before you can comment on or make changes to this bug.