Bug 189036 - Reenable -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
Summary: Reenable -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-27 16:58 PDT by youenn fablet
Modified: 2018-08-28 11:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (30.90 KB, patch)
2018-08-27 17:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (243.44 KB, patch)
2018-08-28 08:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-08-27 16:58:02 PDT 
Reenable -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
Comment 1 youenn fablet 2018-08-27 16:58:33 PDT 
These flags were disable during latest libwebrtc update to ease the refresh, let's reenable them.
Comment 2 youenn fablet 2018-08-27 17:07:58 PDT 
Created attachment 348240 [details]
Patch
Comment 3 youenn fablet 2018-08-28 08:27:27 PDT 
Created attachment 348293 [details]
Patch
Comment 4 Geoffrey Garen 2018-08-28 10:06:57 PDT 
Comment on attachment 348293 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-08-28 11:00:53 PDT 
Comment on attachment 348293 [details]
Patch

Clearing flags on attachment: 348293

Committed r235430: <https://trac.webkit.org/changeset/235430>
Comment 6 WebKit Commit Bot 2018-08-28 11:00:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-28 11:02:13 PDT 
<rdar://problem/43804855>