Bug 188998

Summary: [Curl] Enable Proxy Authentication on WebKit.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, ews-watchlist, galpeter, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=185266
Attachments:
Description Flags
PATCH
none
PATCH none

Basuke Suzuki
Reported 2018-08-27 12:08:04 PDT
Add support for proxy authentication to curl backend running on WebKit. This is follow up implementation of legacy implementation : https://bugs.webkit.org/show_bug.cgi?id=185266
Attachments
PATCH (10.51 KB, patch)
2018-08-27 12:13 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (4.66 KB, patch)
2018-08-27 12:57 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-08-27 12:13:50 PDT
Created attachment 348184 [details] PATCH
Basuke Suzuki
Comment 2 2018-08-27 12:17:47 PDT
Comment on attachment 348184 [details] PATCH Wrong patch....
Basuke Suzuki
Comment 3 2018-08-27 12:57:12 PDT
Created attachment 348189 [details] PATCH
EWS Watchlist
Comment 4 2018-08-27 12:58:47 PDT
Attachment 348189 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:36: "WebCookieManager.h" already included at Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:32 [build/include] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2018-08-27 17:43:51 PDT
Comment on attachment 348189 [details] PATCH Clearing flags on attachment: 348189 Committed r235418: <https://trac.webkit.org/changeset/235418>
WebKit Commit Bot
Comment 6 2018-08-27 17:43:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-27 17:44:20 PDT
<rdar://problem/43778867>
Note You need to log in before you can comment on or make changes to this bug.