Bug 188998

Summary: [Curl] Enable Proxy Authentication on WebKit.
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: PlatformAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, commit-queue, ews-watchlist, galpeter, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=185266
Attachments:
Description Flags
PATCH
none
PATCH none

Description Basuke Suzuki 2018-08-27 12:08:04 PDT 
Add support for proxy authentication to curl backend running on WebKit.
This is follow up implementation of legacy implementation : https://bugs.webkit.org/show_bug.cgi?id=185266
Comment 1 Basuke Suzuki 2018-08-27 12:13:50 PDT 
Created attachment 348184 [details]
PATCH
Comment 2 Basuke Suzuki 2018-08-27 12:17:47 PDT 
Comment on attachment 348184 [details]
PATCH

Wrong patch....
Comment 3 Basuke Suzuki 2018-08-27 12:57:12 PDT 
Created attachment 348189 [details]
PATCH
Comment 4 EWS Watchlist 2018-08-27 12:58:47 PDT 
Attachment 348189 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:36:  "WebCookieManager.h" already included at Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:32  [build/include] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2018-08-27 17:43:51 PDT 
Comment on attachment 348189 [details]
PATCH

Clearing flags on attachment: 348189

Committed r235418: <https://trac.webkit.org/changeset/235418>
Comment 6 WebKit Commit Bot 2018-08-27 17:43:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-27 17:44:20 PDT 
<rdar://problem/43778867>