Bug 188953

Summary:

XMLHTTPRequest.send for Document should have same Content-Type processing rules as String

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, darin, ews-watchlist, fred.wang, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews116 for mac-sierra	none
Patch	none
Patch	none
Patch	none

Rob Buis

Reported 2018-08-26 08:15:30 PDT

Processing rules for Content-Type has been implemented send with String as parameter, but not for Document, but both be treated the same according to the spec: https://xhr.spec.whatwg.org/#the-send()-method

Attachments
Patch (8.32 KB, patch) 2018-08-26 08:23 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip) 2018-08-26 09:27 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.81 MB, application/zip) 2018-08-26 09:38 PDT, EWS Watchlist	no flags	Details
Patch (6.67 KB, patch) 2018-08-26 09:39 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.17 MB, application/zip) 2018-08-26 10:32 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-sierra (2.30 MB, application/zip) 2018-08-26 10:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.06 MB, application/zip) 2018-08-26 11:17 PDT, EWS Watchlist	no flags	Details
Patch (12.25 KB, patch) 2018-08-26 12:21 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (11.87 KB, patch) 2018-08-27 02:40 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (11.86 KB, patch) 2018-08-27 06:10 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2018-08-26 08:23:04 PDT

Created attachment 348090 [details] Patch

EWS Watchlist

Comment 2 2018-08-26 08:24:36 PDT

Attachment 348090 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:17: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-08-26 09:27:41 PDT

Comment on attachment 348090 [details] Patch Attachment 348090 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8988111 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm

EWS Watchlist

Comment 4 2018-08-26 09:27:42 PDT

Created attachment 348092 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-08-26 09:38:14 PDT

Comment on attachment 348090 [details] Patch Attachment 348090 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8988122 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm

EWS Watchlist

Comment 6 2018-08-26 09:38:15 PDT

Created attachment 348093 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Rob Buis

Comment 7 2018-08-26 09:39:37 PDT

Created attachment 348094 [details] Patch

EWS Watchlist

Comment 8 2018-08-26 10:31:58 PDT

Comment on attachment 348094 [details] Patch Attachment 348094 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8988439 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm

EWS Watchlist

Comment 9 2018-08-26 10:32:00 PDT

Created attachment 348095 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-08-26 10:43:35 PDT

Comment on attachment 348094 [details] Patch Attachment 348094 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8988517 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm

EWS Watchlist

Comment 11 2018-08-26 10:43:36 PDT

Created attachment 348096 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-08-26 11:17:06 PDT

Comment on attachment 348094 [details] Patch Attachment 348094 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8988545 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm

EWS Watchlist

Comment 13 2018-08-26 11:17:07 PDT

Created attachment 348097 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

Rob Buis

Comment 14 2018-08-26 12:21:20 PDT

Created attachment 348099 [details] Patch

Rob Buis

Comment 15 2018-08-26 13:30:59 PDT

Comment on attachment 348099 [details] Patch Similar patch for chromium here: https://chromium-review.googlesource.com/c/chromium/src/+/1189602

Rob Buis

Comment 16 2018-08-27 02:40:19 PDT

Created attachment 348129 [details] Patch

WebKit Commit Bot

Comment 17 2018-08-27 05:58:33 PDT

Comment on attachment 348129 [details] Patch Rejecting attachment 348129 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 348129, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/8994316

Rob Buis

Comment 18 2018-08-27 06:10:36 PDT

Created attachment 348135 [details] Patch

WebKit Commit Bot

Comment 19 2018-08-27 06:40:51 PDT

Comment on attachment 348135 [details] Patch Clearing flags on attachment: 348135 Committed r235360: <https://trac.webkit.org/changeset/235360>

WebKit Commit Bot

Comment 20 2018-08-27 06:40:53 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 21 2018-08-27 06:41:23 PDT

<rdar://problem/43752581>

Note You need to log in before you can comment on or make changes to this bug.