Bug 188944

Summary: Shrink size of XMLHttpRequest
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, rniwa, saam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2018-08-25 06:34:31 PDT
Shrink size of XMLHttpRequest
Attachments
Patch (22.29 KB, patch)
2018-08-25 06:35 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-08-25 06:35:59 PDT
Created attachment 348076 [details] Patch
Yusuke Suzuki
Comment 2 2018-08-27 01:31:04 PDT
Committed r235355: <https://trac.webkit.org/changeset/235355>
Radar WebKit Bug Importer
Comment 3 2018-08-27 01:33:31 PDT
<rdar://problem/43746199>
Simon Fraser (smfr)
Comment 4 2018-08-27 09:27:22 PDT
Comment on attachment 348076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348076&action=review > Source/WebCore/xml/XMLHttpRequest.h:203 > + unsigned m_readyState : 3; > + unsigned m_responseType : 3; In cases like this I like to see a comment documenting the enum name.
Yusuke Suzuki
Comment 5 2018-08-27 09:32:02 PDT
Comment on attachment 348076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348076&action=review >> Source/WebCore/xml/XMLHttpRequest.h:203 >> + unsigned m_responseType : 3; > > In cases like this I like to see a comment documenting the enum name. Sounds good! I've added this.
Yusuke Suzuki
Comment 6 2018-08-30 03:24:21 PDT
Committed r235498: <https://trac.webkit.org/changeset/235498>
Note You need to log in before you can comment on or make changes to this bug.