Bug 188927

Summary: [LayoutTests] results.html shows "no expected results" for text diff failures
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jbedard, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188690
Attachments:
Description Flags
Patch ap: review+

Ross Kirsling
Reported 2018-08-24 12:55:38 PDT
After r234993, WinCairo layout tests which have a failing text diff and no -expected.png show up as "had no expected results (probably new)": Before: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234991%20(1085)/results.html After: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234993%20(1086)/results.html Of course, the stdout for RWT still says "Unexpected text-only failures" for all of these: https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/1086/steps/layout-test/logs/stdio
Attachments
Patch (5.83 KB, patch)
2018-08-27 15:38 PDT, Simon Fraser (smfr) 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-08-27 15:38:35 PDT
Created attachment 348219 [details] Patch
Alexey Proskuryakov
Comment 2 2018-08-27 16:19:16 PDT
Comment on attachment 348219 [details] Patch I think that the code is structured quite confusingly, as function names don't make it clear which ones handle results from retries (like "TEXT MISSING" or "TEXT IMAGE"), and which don't. Given test coverage, it seems OK for now.
Simon Fraser (smfr)
Comment 3 2018-08-27 16:32:03 PDT
https://trac.webkit.org/r235409
Radar WebKit Bug Importer
Comment 4 2018-08-27 16:33:58 PDT
<rdar://problem/43775612>
Note You need to log in before you can comment on or make changes to this bug.