Bug 188907

Summary: Add new _webViewRequestPointerLock SPI with a completionHandler
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aestes: review+

Alex Christensen
Reported 2018-08-23 16:09:46 PDT
Add new _webViewRequestPointerLock SPI with a completionHandler
Attachments
Patch (6.75 KB, patch)
2018-08-23 16:12 PDT, Alex Christensen 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-23 16:12:40 PDT
Created attachment 347968 [details] Patch
Andy Estes
Comment 2 2018-08-23 16:31:34 PDT
Comment on attachment 347968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347968&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:100 > - (void)_webViewRequestPointerLock:(WKWebView *)webView WK_API_AVAILABLE(macosx(10.12.3)); Should we deprecate this? > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:101 > +- (void)_webViewRequestPointerLock:(WKWebView *)webView completionHandler:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); _webViewDidRequestPointerLock? > Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:1179 > + if (m_uiDelegate.m_delegateMethods.webViewRequestPointerLock) > + [static_cast<id <WKUIDelegatePrivate>>(delegate) _webViewRequestPointerLock:m_uiDelegate.m_webView]; I'd early return here and un-indent the rest.
Alex Christensen
Comment 3 2018-08-23 16:37:14 PDT
http://trac.webkit.org/r235259
Radar WebKit Bug Importer
Comment 4 2018-08-23 16:38:16 PDT
<rdar://problem/43663953>
Note You need to log in before you can comment on or make changes to this bug.