Bug 188907 - Add new _webViewRequestPointerLock SPI with a completionHandler
Summary: Add new _webViewRequestPointerLock SPI with a completionHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-23 16:09 PDT by Alex Christensen
Modified: 2018-08-23 16:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2018-08-23 16:12 PDT, Alex Christensen 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-23 16:09:46 PDT 
Add new _webViewRequestPointerLock SPI with a completionHandler
Comment 1 Alex Christensen 2018-08-23 16:12:40 PDT 
Created attachment 347968 [details]
Patch
Comment 2 Andy Estes 2018-08-23 16:31:34 PDT 
Comment on attachment 347968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347968&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:100
>  - (void)_webViewRequestPointerLock:(WKWebView *)webView WK_API_AVAILABLE(macosx(10.12.3));

Should we deprecate this?

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:101
> +- (void)_webViewRequestPointerLock:(WKWebView *)webView completionHandler:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

_webViewDidRequestPointerLock?

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:1179
> +    if (m_uiDelegate.m_delegateMethods.webViewRequestPointerLock)
> +        [static_cast<id <WKUIDelegatePrivate>>(delegate) _webViewRequestPointerLock:m_uiDelegate.m_webView];

I'd early return here and un-indent the rest.
Comment 3 Alex Christensen 2018-08-23 16:37:14 PDT 
http://trac.webkit.org/r235259
Comment 4 Radar WebKit Bug Importer 2018-08-23 16:38:16 PDT 
<rdar://problem/43663953>