Bug 188901 – [CMake] Have checks are not getting set inside CMake properly

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Don Olmstead]

Currently it looks like CMake have checks are not being set properly within the build.

After https://trac.webkit.org/changeset/235241/webkit I noticed that the check for HAVE_MALLOC_TRIM within PerformanceTests/CMakeLists.txt was not set to OFF but instead was set to HAVE_MALLOC_TEST_value.

The cmakeconfig.h however was correct.

[Don Olmstead]

Created attachment 347951 [details]
Patch

[Michael Catanzaro]

Comment on attachment 347951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347951&action=review

> PerformanceTests/CMakeLists.txt:5
> +else ()
> +    message(WARNING "MallocBench is not available on this platform")

Isn't this warning message just going to be annoying?

> Source/cmake/WebKitFeatures.cmake:365
> -    SET_AND_EXPOSE_TO_BUILD(${_variable} ${_variable}_value)
> +    SET_AND_EXPOSE_TO_BUILD(${_variable} ${${_variable}_value})

Ouch.

[Don Olmstead]

Comment on attachment 347951 [details]
Patch

WinCairo EWS had an internal failure. AppleWin EWS is hitting a new compilation error.

I think this is fine but will roll out if WinCairo has problems.

[WebKit Commit Bot]

Comment on attachment 347951 [details]
Patch

Clearing flags on attachment: 347951

Committed r235253: <https://trac.webkit.org/changeset/235253>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43662371>