Bug 188856

Summary:

Restructure and rename http/tests/websocket/construct-in-detached-frame-resource-load-statistics.html to address flakiness

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

Tools / Tests

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=188757

Attachments:

Description	Flags
Patch for landing	none
Archive of layout-test-results from webkit-cq-01 for mac-sierra	none
Patch for landing	none
Patch for landing	none

John Wilander

Reported 2018-08-22 10:41:54 PDT

http/tests/websocket/construct-in-detached-frame-resource-load-statistics.html is flaky as reported in https://bugs.webkit.org/show_bug.cgi?id=188757.

Attachments
Patch for landing (8.34 KB, patch) 2018-08-22 10:45 PDT, John Wilander	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-sierra (2.30 MB, application/zip) 2018-08-22 11:51 PDT, WebKit Commit Bot	no flags	Details
Patch for landing (10.31 KB, patch) 2018-08-22 12:28 PDT, John Wilander	no flags	Details Formatted Diff Diff
Patch for landing (3.20 KB, patch) 2018-08-22 15:30 PDT, John Wilander	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

John Wilander

Comment 1 2018-08-22 10:45:53 PDT

Created attachment 347819 [details] Patch for landing

WebKit Commit Bot

Comment 2 2018-08-22 11:51:09 PDT

Comment on attachment 347819 [details] Patch for landing Rejecting attachment 347819 [details] from commit-queue. New failing tests: http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html Full output: https://webkit-queues.webkit.org/results/8947087

WebKit Commit Bot

Comment 3 2018-08-22 11:51:10 PDT

Created attachment 347822 [details] Archive of layout-test-results from webkit-cq-01 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-sierra Platform: Mac OS X 10.12.6

John Wilander

Comment 4 2018-08-22 11:59:41 PDT

Forgot to change the test expectations. :/ Will fix.

John Wilander

Comment 5 2018-08-22 12:28:43 PDT

Created attachment 347828 [details] Patch for landing

WebKit Commit Bot

Comment 6 2018-08-22 13:07:26 PDT

Comment on attachment 347828 [details] Patch for landing Clearing flags on attachment: 347828 Committed r235193: <https://trac.webkit.org/changeset/235193>

WebKit Commit Bot

Comment 7 2018-08-22 13:07:27 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-08-22 13:08:19 PDT

<rdar://problem/43617155>

John Wilander

Comment 9 2018-08-22 15:30:09 PDT

Reopening to attach new patch.

John Wilander

Comment 10 2018-08-22 15:30:10 PDT

Created attachment 347854 [details] Patch for landing

WebKit Commit Bot

Comment 11 2018-08-22 16:10:44 PDT

Comment on attachment 347854 [details] Patch for landing Clearing flags on attachment: 347854 Committed r235210: <https://trac.webkit.org/changeset/235210>

WebKit Commit Bot

Comment 12 2018-08-22 16:10:45 PDT

All reviewed patches have been landed. Closing bug.

John Wilander

Comment 13 2018-08-23 07:56:30 PDT

Flakiness dashboard now indicates that this test is no longer failing. It is slow, but that is expected. I may revisit to see if I can speed it up but it's waiting for a timer to fire.

Note You need to log in before you can comment on or make changes to this bug.